Fix problem with vector handling in ST3 derivatives#4
Open
BerriJ wants to merge 1 commit intogamlss-dev:mainfrom
Open
Fix problem with vector handling in ST3 derivatives#4BerriJ wants to merge 1 commit intogamlss-dev:mainfrom
BerriJ wants to merge 1 commit intogamlss-dev:mainfrom
Conversation
Author
|
Did you have a chance to review this? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The ST3 derivatives enforce various bounds on the
dsq1anddsq2objects usingifelse.However,
ifelsepoorly handles non-matching lengths of the inputs. Consider this example:This evaluates to
1.Similarly in
ST3()$dldmEvaluate to the first element of the vector
(tau+1)/(tau+dsq1)and(tau+1)/(tau+dsq2). I believe outputting the whole vectors(tau+1)/(tau+dsq1)and(tau+1)/(tau+dsq2)would be correct here.I suggest to fix that by repeating the input so that it matches the length of
ywhich determines the length ofdsq1anddsq2. Like so:rep(tau, length(y)).This is what this PR does.
Best regards,
BerriJ