Skip to content

fix: typo with deps #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 13, 2024
Merged

fix: typo with deps #18

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d4cbb6a
fix(deps)!: change deps setting
yicr Nov 13, 2024
f0b4fc4
fix!: typo
yicr Nov 13, 2024
f1f40f7
chore(docs): update auto generated api document
yicr Nov 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions .projen/deps.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion .projen/tasks.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

12 changes: 6 additions & 6 deletions .projenrc.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,12 +9,12 @@ const project = new awscdk.AwsCdkConstructLibrary({
name: '@gammarers/aws-codeconnections-host-custom-resource',
projenrcTs: true,
repositoryUrl: 'https://github.com/gammarers/aws-codeconnections-host-custom-resource.git',
// deps: [
// '@gammarers/aws-resource-naming@^0.8.0',
// ],
// devDeps: [
// '@gammarers/[email protected]',
// ],
deps: [
'@gammarers/[email protected]',
],
devDeps: [
'@gammarers/[email protected]',
],
peerDeps: [
'@gammarers/aws-resource-naming@^0.8.0',
],
Expand Down
6 changes: 3 additions & 3 deletions API.md
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 3 additions & 0 deletions package.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,7 @@ export interface CodeConnectionsHostCustomResourceProps {
readonly providerType: CodeConnectionsHostProviderType;
//readonly resouceNamingOption?: ResourceNamingOptions;
// readonly resouceNamingOption?: { type: ResourceNaming.NamingType.DEFAULT } | { type: ResourceNaming.NamingType.AUTO } | CustomNaming;
readonly resouceNamingOption?: ResourceNamingOption;
readonly resourceNamingOption?: ResourceNamingOption;
}

export class CodeConnectionsHostCustomResource extends cr.AwsCustomResource {
Expand All @@ -89,7 +89,7 @@ export class CodeConnectionsHostCustomResource extends cr.AwsCustomResource {
functionName: `custom-resource-codeconnection-host-${random}-func`,
functionRoleName: `custom-resource-codeconnection-host-${random}-func-exc-role`,
};
const names = ResourceNaming.naming(autoNaming, props.resouceNamingOption as ResourceNamingOptions);
const names = ResourceNaming.naming(autoNaming, props.resourceNamingOption as ResourceNamingOptions);
// const naming = {
// names: autoNaming,
// };
Expand Down
2 changes: 1 addition & 1 deletion test/custom-resource.bitbucket.option.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ describe('CustomResource Testing', () => {
name: 'bitbucket.example.com',
providerEndpoint: 'https://bitbucket.example.com',
providerType: CodeConnectionsHostProviderType.BIT_BUCKET,
resouceNamingOption: {
resourceNamingOption: {
type: ResourceNamingType.AUTO,
},
});
Expand Down