fix panic if copying in exactly the buffer size#50
Merged
Conversation
If Copy or CopyInSlice copied exactly the buffer size nubber of elements, and then an item was removed from the back of the deque, this caused a panic. This was due to the tail not being wrapped around to the front of the buffer if the data copied in aligned with the buffer boundary. This is fixed by properly wrapping the tail index to the start of the buffer. Closes #47
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If Copy or CopyInSlice copied exactly the buffer size nubber of elements, and then an item was removed from the back of the deque, this caused a panic. This was due to the tail not being wrapped around to the front of the buffer if the data copied in aligned with the buffer boundary. This is fixed by properly wrapping the tail index to the start of the buffer.
Closes #47