Open
Conversation
I got the message: PHP Warning: "continue" targeting switch is equivalent to "break". Did you mean to use "continue 2"? in /usr/share/ganglia-webfrontend/functions.php on line 732 This messages is likely new with php7.3. Will be an error with PHP8. For details see https://wiki.php.net/rfc/continue_on_switch_deprecation This in one small step to get ready for php8. See ganglia#361
Contributor
Author
|
I now think that the following change would be better (pseudo-patch): |
Contributor
|
Thanks, this Warning is fixed now in PR #376, as the same in your PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I got the message:
PHP Warning: "continue" targeting switch is equivalent to "break". Did you mean to use "continue 2"?
in /usr/share/ganglia-webfrontend/functions.php on line 732
This messages is likely new with php7.3. Will be an error with PHP8.
For details see https://wiki.php.net/rfc/continue_on_switch_deprecation
This in one small step to get ready for php8. See #361