Fix: month, year, physical_view, etc. in php8 #379
Open
berlin2123 wants to merge 10 commits intoganglia:masterfrom
Open
Fix: month, year, physical_view, etc. in php8 #379berlin2123 wants to merge 10 commits intoganglia:masterfrom
berlin2123 wants to merge 10 commits intoganglia:masterfrom
Conversation
…" in /usr/share/ganglia/mobile_helper.php:269
…$haystack) must be of type array, null given in /usr/share/ganglia/get_ganglia.php:10
…($value) must be of type Countable|array, null given in /usr/share/ganglia/pie.php:279
This was referenced Mar 4, 2024
Fix: PHP Fatal error: Uncaught TypeError: number_format(): Argument ganglia#1 ($num) must be of type float, string given in /usr/share/ganglia/graph.d/metric.php:58
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
1, fix error of 'month' or 'year' view inside php8,
2, update version number for next release, and change "Check for Updates" URL to Github
3, fix error of mobile view
4, fix error of physical_view.php #380 , and other 'while each'
5, other fix for php8.