Avoid use of reserved C99 keyword "bool" as a variable name#13
Closed
jengelh wants to merge 1 commit intogap-packages:masterfrom
Closed
Avoid use of reserved C99 keyword "bool" as a variable name#13jengelh wants to merge 1 commit intogap-packages:masterfrom
jengelh wants to merge 1 commit intogap-packages:masterfrom
Conversation
gcc15 comes with -std=c23 by default. The C99 bool keyword is still in effect. C23 has only deprecated it, not removed it. gcc-15 output: ``` src/fplsa4.c: In function ‘ReadBooleanFromFile’: src/fplsa4.c:7013:7: error: ‘bool’ cannot be used here 7013 | int bool; src/fplsa4.c:7013:7: note: ‘bool’ is a keyword with ‘-std=c23’ onwards src/fplsa4.c:7013:3: warning: useless type name in empty declaration 7013 | int bool; ``` gcc-14 output: ``` src/fplsa4.c: In function ‘ReadBooleanFromFile’: src/fplsa4.c:7027:10: warning: ‘bool’ may be used uninitialized [-Wmaybe-uninitialized] 7027 | return bool; ```
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #13 +/- ##
==========================================
+ Coverage 26.61% 26.63% +0.02%
==========================================
Files 2 2
Lines 3660 3661 +1
Branches 730 730
==========================================
+ Hits 974 975 +1
Misses 2561 2561
Partials 125 125
🚀 New features to boost your workflow:
|
Member
|
Duplicate of #12 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
gcc15 comes with -std=c23 by default. The C99 bool keyword is still in effect. C23 has only deprecated it, not removed it.
gcc-15 output:
gcc-14 output: