Merge branch 'master' of https://github.com/gap-packages/modisom

Author: Leo

.github/workflows/CI.yml

@@ -33,17 +33,17 @@ jobs:
           - stable-4.9
 
     steps:
-      - uses: actions/checkout@v4
+      - uses: actions/checkout@v5
       - uses: gap-actions/setup-gap@v2
         with:
           GAPBRANCH: ${{ matrix.gap-branch }}
       - uses: gap-actions/build-pkg@v1
-      - uses: gap-actions/run-pkg-tests@v2
-      - uses: gap-actions/run-pkg-tests@v2
+      - uses: gap-actions/run-pkg-tests@v3
+      - uses: gap-actions/run-pkg-tests@v3
         with:
           only-needed: true
       - uses: gap-actions/process-coverage@v2
-      - uses: codecov/codecov-action@v4
+      - uses: codecov/codecov-action@v5
         with:
           token: ${{ secrets.CODECOV_TOKEN }}
 
@@ -53,7 +53,7 @@ jobs:
     runs-on: ubuntu-latest
 
     steps:
-      - uses: actions/checkout@v4
+      - uses: actions/checkout@v5
       - uses: gap-actions/setup-gap@v2
       - uses: gap-actions/build-pkg-docs@v1
         with:

.github/workflows/release.yml

@@ -0,0 +1,35 @@
+name: Release
+
+on:
+  workflow_dispatch:
+    inputs:
+      dry-run:
+        description: "Only create an archive containing the release instead of publishing it on GitHub"
+        type: boolean
+        required: false
+        default: false
+      force:
+        description: "Allow overwriting an existing release, or making a release with an incorrect date"
+        type: boolean
+        required: false
+        default: false
+
+permissions: write-all
+
+jobs:
+  release:
+    name: "Release the GAP package"
+    runs-on: ubuntu-latest
+
+    steps:
+      - uses: actions/checkout@v5
+      - uses: gap-actions/setup-gap@v3
+      - uses: gap-actions/build-pkg-docs@v2
+        with:
+          use-latex: true
+      - uses: gap-actions/release-pkg@v1
+        with:
+          dry-run: ${{ inputs.dry-run }}
+          force: ${{ inputs.force }}
+      - uses: gap-actions/update-gh-pages@v1
+        if: ${{ !inputs.dry-run }}

PackageInfo.g

@@ -6,7 +6,7 @@ SetPackageInfo( rec(
 PackageName := "ModIsom",
 Subtitle := "Computing automorphisms and checking isomorphisms for modular group algebras of finite p-groups",
 Version := "3.0.2",
-Date := "28/12/2024", # dd/mm/yyyy format
+Date := "13/09/2025", # dd/mm/yyyy format
 License := "GPL-2.0-or-later",
 
 Persons := [
@@ -118,7 +118,6 @@ PackageDoc := rec(
   PDFFile   := "doc/manual.pdf",
   SixFile   := "doc/manual.six",
   LongTitle := "Computing with nilpotent associative algebras",
-  Autoload  := true
 ),
 
 
@@ -131,7 +130,6 @@ Dependencies := rec(
 
 BannerString := Concatenation( "Loading ModIsom ", ~.Version, "... \n"),
 AvailabilityTest := ReturnTrue,
-Autoload := false,
 TestFile := "tst/testall.g",
 Keywords := ["modular isomorphism problem",
              "automorphism group",

README.md

@@ -1,4 +1,4 @@
-[![Build Status](https://github.com/gap-packages/modisom/workflows/CI/badge.svg?branch=master)](https://github.com/gap-packages/modisom/actions?query=workflow%3ACI+branch%3Amaster)
+[![CI](https://github.com/gap-packages/modisom/actions/workflows/CI.yml/badge.svg)](https://github.com/gap-packages/modisom/actions/workflows/CI.yml)
 [![Code Coverage](https://codecov.io/github/gap-packages/modisom/coverage.svg?branch=master&token=)](https://codecov.io/gh/gap-packages/modisom)
 
 

doc/make_doc

@@ -2,25 +2,20 @@
 set -e
 
 echo "TeXing documentation"
+# delete old stuff to avoid spurious or "hidden errors" caused by their presence
+rm -f manual.aux manual.pdf manual.idx manual.ilg manual.ind manual.lab manual.log manual.six manual.toc
 # TeX the manual
-tex manual
-# ... and build its bibliography (uncomment if there is a `manual.bib')
+pdftex manual
+# ... and build its bibliography
 bibtex manual
-# TeX the manual again to incorporate the ToC ... and build the index
-tex manual
-tex manual
+# TeX the manual again to incorporate the ToC 
+pdftex manual
+# ... and build the index
 ../../../doc/manualindex manual
 # Finally TeX the manual again to get cross-references right
-tex manual
-# Create PDF version
-pdftex manual; pdftex manual 
+pdftex manual
 
 # The HTML version of the manual
-rm -rf ../htm
-mkdir ../htm
+mkdir -p ../htm
 echo "Creating HTML documentation"
 ../../../etc/convert.pl -i -u -c -n ModIsom . ../htm
-
-#############################################################################
-##
-#E

gap/grpalg/collect.gi

@@ -5,13 +5,6 @@
 ##
 ## functions to work with tables (in the sense of ModIsom) which correspond to quotients of the augmentation ideal I of a group algebra of a finite p-group over a field of characteristic p modulo a power of I. In particular, to generate the table for this quotient
 
-# Input: A list
-# Output: The nonzero positions of the list
-BindGlobal("PosNonzero", function(list)
-    return PositionsProperty(list, x -> not IsZero(x));
-end);
-
-
 # Input: Linear combination of words. A word is a list of pairs of natural numbers. We think e.g. g1^2*g3 = [[1,2],[3,1]]
 # Output: Same linear combination (in the math sense) where each word 
 #         appears at most once
@@ -198,7 +191,7 @@ local w, sw, pos, p;
 
     sw := 0;
     w := [ ];
-    pos := PosNonzero(exp);
+    pos := PositionNonZero(exp);
 
     for p in pos do
         sw := sw + 1;
@@ -443,7 +436,7 @@ local F, p, exp, pos1, i, j, pows, pos, combs, v, c, w, s, m, tup, coefprod, exp
         # Check if weight of p-th power exceeds level
         if p*T.pre.weights[i] <= lvl then 
             pows := StructuralCopy(T.pre.jen.pows[pos1]);
-            pos := PosNonzero(pows);
+            pos := PositionNonZero(pows);
             pows := pows{pos};
             combs := Combinations([1..Length(pos)]);
             Remove(combs, 1); 
@@ -523,7 +516,7 @@ local F, p, exp, pos1, i, j, pows, pos, combs, v, c, w, s, m, tup, coefprod, exp
                     pows := StructuralCopy(T.pre.jen.coms[poscom][2]);
                     pows[pos1] := 1;
                     pows[pos2] := 1;
-                    pos := PosNonzero(pows);
+                    pos := PositionNonZero(pows);
                     pows := pows{pos};
                     combs := Combinations([1..Length(pos)]);
                     v := [ ];
@@ -591,7 +584,7 @@ end);
 # Input: Table and maximal weight we want. Typically output from PreSet
 # Output: None. T.powwords, T.commwords, T.dim, T.wgs are set
 BindGlobal("WordFillTable", function(T, lvl)
-local F, p, s1, l, i, pos1, expw1, w1, sortweights1, sortexpw1, f1, posf1, s2, post2, expw2, w2, sortweights2, sortexpw2, f2, posf2, dep, mm, vec, posvec, fac1, posnonzero, v;
+local F, p, s1, l, i, pos1, expw1, w1, sortweights1, sortexpw1, f1, posf1, s2, post2, expw2, w2, sortweights2, sortexpw2, f2, posf2, dep, mm, vec, posvec, fac1, v;
 
     F := T.fld;
     p := Characteristic(F);

gap/grpalg/tabletoalgebraandback.gi

@@ -24,7 +24,7 @@ local k, maxweight, i, lim, sup, coeffs, v0, res, exps, nonzeroexps, sum, S, ini
     ## for each element g1^e1...gm^em we convert g1^e1...gm^em to an expression in the Jennings basis using the formulas known for this
     for i in [1..Size(sup)] do
         exps := ExponentsOfPcElement(T.pre.jen.pcgs, sup[i]){[1..lim]};
-        nonzeroexps := PosNonzero(exps);
+        nonzeroexps := PositionNonZero(exps);
         sum := ShallowCopy(v0);
         # run over all supsets of non-zero exponents. Each gives a summand
         for S in Combinations( nonzeroexps ) do