Skip to content

chore: Simplify Dockerfile #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
limakzi merged 1 commit into from
Apr 9, 2025
Merged

chore: Simplify Dockerfile #25

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 1 addition & 5 deletions .github/workflows/main.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,9 +36,6 @@ jobs:
- 4.12.2
- 4.12.1
- 4.12.0
platform:
- linux/amd64
- linux/arm64

steps:
- name: 👨‍💻 git -- checkout
Expand Down Expand Up @@ -74,12 +71,11 @@ jobs:
with:
context: ./src/dockerfiles/${{ matrix.image }}
file: ./src/dockerfiles/${{ matrix.image }}/Dockerfile
platforms: ${{ matrix.platform }}
push: ${{ ! github.event_name == 'pull_request' }}
tags: ${{ steps.meta.outputs.tags }}
labels: ${{ steps.meta.outputs.labels }}
platforms: linux/amd64,linux/arm64
cache-from: type=gha
cache-to: type=gha,mode=max`
build-args: |
PLATFORM=${{ matrix.platform }}
GAP_VERSION=${{ matrix.gap-version }}
4 changes: 1 addition & 3 deletions src/dockerfiles/ubuntu-2204-lts/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,3 @@
ARG PLATFORM="linux/arm64"

## {{{
ARG GAP_USER_USERNAME="gap"
ARG GAP_USER_GROUPNAME="gap"
Expand Down Expand Up @@ -27,7 +25,7 @@ ARG PACKAGE_MANAGER_DOWNLOAD_URL="https://github.com/gap-packages/PackageManager



FROM --platform=${PLATFORM} ubuntu:22.04 AS base
FROM ubuntu:22.04 AS base
ARG GAP_USER_GID
ARG GAP_USER_GROUPNAME
ARG GAP_USER_UID
Expand Down
Loading