Skip to content

fix: Set default gap-version to newest one #84

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
limakzi merged 3 commits into from
May 13, 2025
Merged

fix: Set default gap-version to newest one #84

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3847f18
fix: Set default gap-version to newest one
limakzi May 12, 2025
22c09f4
fix: Add clean step
limakzi May 12, 2025
3df48fc
fix: Do not fail fast
limakzi May 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/main.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ jobs:
needs:
- define-matrix
strategy:
fail-fast: true
fail-fast: false
matrix:
gap-version: ${{ fromJSON(needs.define-matrix.outputs.versions) }}
operating-system-base: ${{ fromJSON(needs.define-matrix.outputs.systems) }}
Expand Down
14 changes: 9 additions & 5 deletions src/dockerfiles/ubuntu-2204-lts/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
## {{{
ARG GAP_VERSION="4.13.1"
ARG GAP_VERSION="4.14.0"
ARG PACKAGE_MANAGER_VERSION="1.6.2"
## }}}

Expand Down Expand Up @@ -35,7 +35,8 @@ ARG GAP_USER_HOMEDIR
RUN groupadd --system --gid ${GAP_USER_GID} ${GAP_USER_GROUPNAME} && \
useradd --system --gid ${GAP_USER_GID} --home-dir ${GAP_USER_HOMEDIR} --create-home ${GAP_USER_USERNAME}

RUN apt-get update --yes && \
RUN apt-get clean && \
apt-get update --yes && \
apt-get install --no-install-recommends --quiet --yes \
ca-certificates \
curl \
Expand Down Expand Up @@ -63,7 +64,8 @@ ARG GAP_USER_HOMEDIR
ARG GAP_USER_USERNAME
ARG GAP_USER_GROUPNAME

RUN apt-get update --yes && \
RUN apt-get clean && \
apt-get update --yes && \
apt-get install --no-install-recommends --quiet --yes \
autoconf \
build-essential \
Expand Down Expand Up @@ -94,7 +96,8 @@ ARG PACKAGE_MANAGER_DOWNLOAD_URL
ENV PATH="${GAP_USER_HOMEDIR}/gap-${GAP_VERSION}/:${PATH}"
ENV LD_LIBRARY_PATH="${GAP_USER_HOMEDIR}/gap-${GAP_VERSION}/lib"

RUN apt-get update --yes && \
RUN apt-get clean && \
apt-get update --yes && \
apt-get install --no-install-recommends --quiet --yes \
ca-certificates \
curl \
Expand Down Expand Up @@ -133,7 +136,8 @@ ARG GAP_USER_HOMEDIR
ARG GAP_USER_USERNAME
ARG GAP_USER_GROUPNAME

RUN apt-get update --yes && \
RUN apt-get clean && \
apt-get update --yes && \
apt-get install --no-install-recommends --quiet --yes \
autoconf \
build-essential \
Expand Down
Loading