fix: Cut qemu #89
Merged
fix: Cut qemu #89
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR aims to remove the outdated qemu setup step to streamline the workflow and avoid unnecessary steps.
- Removed the qemu setup step from the workflow file.
- Minor formatting adjustments following the removal.
Comments suppressed due to low confidence (1)
.github/workflows/worflow-dispatch-build.yaml:64
- There is an extraneous backtick at the end of this line which may cause YAML parsing issues. Please remove the stray backtick.
cache-to: type=gha,mode=max`
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR removes the QEMU setup step and drops the explicit multi-architecture platform configuration from the GitHub Actions build.
- Removed
docker/setup-qemu-actionstep - Removed
platforms: linux/amd64,linux/arm64from the buildx step
Comments suppressed due to low confidence (1)
.github/workflows/worflow-dispatch-build.yaml:62
- Removing the
platformskey along with the QEMU setup will disable ARM64 builds on an AMD64 runner. If multi-architecture images are still required, consider restoring theplatformssetting or usingbuildx build --platformflags.
platforms: linux/amd64,linux/arm64
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.