Use Info in FinitePolycyclicCollector_IsConfluent#5911
Merged
fingolfin merged 2 commits intogap-system:masterfrom Jan 28, 2025
Merged
Use Info in FinitePolycyclicCollector_IsConfluent#5911fingolfin merged 2 commits intogap-system:masterfrom
FinitePolycyclicCollector_IsConfluent#5911fingolfin merged 2 commits intogap-system:masterfrom
Conversation
... instead of commented out debug messages. The new `Info` statements are taken from the `IsConfluent` method for `IsPcGroup` from `lib/rwspcgrp.gi`.
fingolfin
added
topic: library
release notes: not needed
ThomasBreuer
approved these changes
Jan 28, 2025
Contributor
ThomasBreuer
left a comment
ThomasBreuer
left a comment
There was a problem hiding this comment.
Nice.
(Having a test would be difficult because of the involved timings.)
Co-authored-by: Thomas Breuer <sam@math.rwth-aachen.de>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
... instead of commented out debug messages. The new
Infostatements are taken from theIsConfluentmethod forIsPcGroupfromlib/rwspcgrp.gi.