Load the whole GAP library before loading packages#5914
Merged
fingolfin merged 1 commit intogap-system:masterfrom Jan 24, 2025
Merged
Load the whole GAP library before loading packages#5914fingolfin merged 1 commit intogap-system:masterfrom
fingolfin merged 1 commit intogap-system:masterfrom
Conversation
Up to now, the "implementation part" of the GAP library was delayed until a package got loaded that claimed to need the whole library. The idea was to have calls to functions from some packages inside the GPA library. This was used for some time by the packages primgrp and transgrp, but meanwhile the GAP library can apparently be loaded without problems before the declaration part of these packages has been loaded.
ThomasBreuer
added
topic: packages
Contributor
|
I'm happy with this, it makes sense to get GAP fully loaded before we start loading packages, I'm just curious if there is any reason you wanted to make the change? |
Contributor
Author
|
When working on #5912, I noticed that packages can still get partially loaded before the library. Removing this feature first of all simplifies the code. Perhaps it will simplify also further changes in the handling of packages. |
fingolfin
approved these changes
Jan 24, 2025
Member
fingolfin
left a comment
fingolfin
left a comment
There was a problem hiding this comment.
Simplifies the package loading mechanism, good -- that makes it a bit easier to debug and possibly modify in the future.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Up to now, the "implementation part" of the GAP library was delayed until a package got loaded that claimed to need the whole library.
The idea was to have calls to functions from some packages inside the GAP library, without syntax warnings, and to use some gapdoc functions already during startup.
This was used for some time for the packages gapdoc, primgrp, and transgrp, but meanwhile the GAP library can apparently be loaded without problems before the declaration part of these packages has been loaded.