Improve printing of nested expressions#5918
Merged
ChrisJefferson merged 1 commit intogap-system:masterfrom Feb 13, 2025
Merged
Conversation
Specifically, make it better at eliding redundant parenthesis. We do so by changing the code so that the PrintPrecedence is reset to 0 whenever a expression is print that is not a unary or binary op, and then restored afterwards. For "leave" expressions such as integer literals this has no effect. But for expression that can have further subexpressions, such as function expressions, list expression, permutation expressions etc., this allows us to avoid redundant parenthesis.
fingolfin
added
topic: kernel
release notes: not needed
Member
Author
|
Any thoughts on this @ChrisJefferson ? |
ChrisJefferson
approved these changes
Feb 13, 2025
Contributor
|
I had a good poke, just to check I couldn't find any issues with this, but it all seems good. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Specifically, make it better at eliding redundant parenthesis. We do so by changing the code so that the PrintPrecedence is reset to 0 whenever a expression is print that is not a unary or binary op, and then restored afterwards. For "leave" expressions such as integer literals this has no effect. But for expression that can have further subexpressions, such as function expressions, list expression, permutation expressions etc., this allows us to avoid redundant parenthesis.
Resolves #4523 by @zickgraf