remove the ConjugateGroup method based on nice monom.#6197
Merged
fingolfin merged 2 commits intogap-system:masterfrom Jan 19, 2026
Merged
remove the ConjugateGroup method based on nice monom.#6197fingolfin merged 2 commits intogap-system:masterfrom
ConjugateGroup method based on nice monom.#6197fingolfin merged 2 commits intogap-system:masterfrom
Conversation
I think that using nice monomorphisms in `ConjugateGroup` methods is a bad idea: When this works (that is, when the conjugating element can be mapped under the nice monomorphism of the group) then one first maps the group and the element under the nice monomorphism, then conjugates in the image, and then pulls back the result under the monomorphism. The group which one gets this way (via `GroupByNiceMonomorphism`) knows almost nothing except the nice monomorphism. And in general this will not work because the conjugating element will not fit. Due to the omission of the `ConjugateGroup` method, we will lose the known `NiceMonomorphism` in the result of `ConjugateGroup`. Eventually this can be "reinserted" by installing a new `ConjugateGroup` method with requirement `IsGroup and HasNiceMonomorphism` that creates a nice monomorphism of the conjugated group. Do we want this? (In certain cases, this will be not what one wants: Perhaps we conjugate the group just in order to get a better behaved group, and then setting a "nice monomorphism" in this group that delegates tasks via the "ugly" original group is a bad idea.)
ThomasBreuer
added
topic: library
release notes: not needed
Member
|
Has a merge conflict now |
fingolfin
approved these changes
Jan 19, 2026
hulpke
pushed a commit
to hulpke/gap
that referenced
this pull request
Feb 19, 2026
) I think that using nice monomorphisms in `ConjugateGroup` methods is a bad idea: When this works (that is, when the conjugating element can be mapped under the nice monomorphism of the group) then one first maps the group and the element under the nice monomorphism, then conjugates in the image, and then pulls back the result under the monomorphism. The group which one gets this way (via `GroupByNiceMonomorphism`) knows almost nothing except the nice monomorphism. And in general this will not work because the conjugating element will not fit. Due to the omission of the `ConjugateGroup` method, we will lose the known `NiceMonomorphism` in the result of `ConjugateGroup`. Eventually this can be "reinserted" by installing a new `ConjugateGroup` method with requirement `IsGroup and HasNiceMonomorphism` that creates a nice monomorphism of the conjugated group. Do we want this? (In certain cases, this will be not what one wants: Perhaps we conjugate the group just in order to get a better behaved group, and then setting a "nice monomorphism" in this group that delegates tasks via the "ugly" original group is a bad idea.)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I think that using nice monomorphisms in
ConjugateGroupmethods is a bad idea:When this works (that is, when the conjugating element can be mapped under the nice monomorphism of the group)
then one first maps the group and the element under the nice monomorphism, then conjugates in the image,
and then pulls back the result under the monomorphism. The group which one gets this way (via
GroupByNiceMonomorphism) knows almost nothing except the nice monomorphism.And in general this will not work because the conjugating element will not fit.
Due to the omission of the
ConjugateGroupmethod, we will lose the knownNiceMonomorphismin the result ofConjugateGroup. Eventually this can be "reinserted" by installing a newConjugateGroupmethod with requirementIsGroup and HasNiceMonomorphismthat creates a nice monomorphism of the conjugated group. Do we want this?(In certain cases, this will be not what one wants: Perhaps we conjugate the group just in order to get a better behaved group, and then setting a "nice monomorphism" in this group that delegates tasks via the "ugly" original group is a bad idea.)