This repository was archived by the owner on Jan 30, 2021. It is now read-only.
Added functionality and fixed various bugs#31
Open
mdance wants to merge 7 commits intogaqzi:masterfrom
Open
Conversation
|
I've proposed we make a community module where more eyes can help drive it forward ansible-collections/community.general#1562 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Running this role on my mac, I ran into several problems, and added a few improvements...
On mac, the user and group are not the same so without the ability to configure the group, the command was failing with chgrp errors.
I also needed the ability to add custom SSH configuration directives to configure port forwarding, etc. so added the extra parameter.
I also found various problems where duplicate directives were being created, or incorrect ssh entries were being overridden if the host was too generic (dev for example) because the check_host method checks for all the searchable text in the SSH entry. I restricted this to make sure the host property matches