This repository was archived by the owner on Sep 11, 2022. It is now read-only.
add support for scrolling the sticky element if its higher from window#289
Open
DeepSkyDad wants to merge 1 commit intogarand:masterfrom
Open
add support for scrolling the sticky element if its higher from window#289DeepSkyDad wants to merge 1 commit intogarand:masterfrom
DeepSkyDad wants to merge 1 commit intogarand:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In our use case, we have a webshop sidebar filters which can expand and be quite long height-wise. I extended your library so it has a config key "scrollStickyElement", which syncs scrolling of sticky element with main page. Should you find this snippet useful, you can merge, otherwise close the request.