remove cluster-admin and add specific role for identity#1
Open
crigertg wants to merge 2 commits intogardener-community:mainfrom
Open
remove cluster-admin and add specific role for identity#1crigertg wants to merge 2 commits intogardener-community:mainfrom
crigertg wants to merge 2 commits intogardener-community:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
How to categorize this PR?
/area security
/kind enhancement
What this PR does / why we need it:
The identity service (dex) is running with
cluster-adminprivileges, which is not required. This violates least-privilege best practices and can be an issue for security audits.The dex docs state which permissions are required for the service to work.
This PR introduces a new role specific for the identity service and assigns only the required permissions. The
cluster-adminClusterRoleBindingis removed.I've also updated the naming of the resources since
garden.sapcloud.iois not used anywhere else (AFAIK).Which issue(s) this PR fixes:
NONE