Skip to content

enh: Allow trusted-checkout action user to set github-server-url #1510

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
zkdev merged 1 commit into from
Feb 3, 2026
Merged

enh: Allow trusted-checkout action user to set github-server-url #1510

zkdev merged 1 commit into from
Feb 3, 2026

Conversation

@zkdev
Copy link
Member

@zkdev zkdev commented Jan 20, 2026 •
edited
Loading

Useful for scenarios where trusted-checkout is used to pull repositories from another GitHub (Enterprise) instance.

Release note:

`trusted-checkout` action now exposes `github-server-url` input, allowing to resolve repositories from different GitHub instances.

@gardener-prow gardener-prow bot added do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 20, 2026
ccwienk
ccwienk requested changes Jan 20, 2026
View reviewed changes
Copy link
Member

@ccwienk ccwienk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think we should rather pass github-api-url

8R0WNI3
8R0WNI3 requested changes Jan 21, 2026
View reviewed changes
@gardener-robot
Copy link

gardener-robot commented Jan 23, 2026

@TuanAnh17N You have pull request review open invite, please check

@zkdev
Copy link
Member Author

zkdev commented Jan 26, 2026

@ccwienk

i think we should rather pass github-api-url

I do not see a good solution to extract github-server-url from github-api-url in a generic way.
We would have to support both cases, subdomain and path:

  • api-url: api.github.com
    server-url: github.com

  • api-url: github.my.fancy.corp/api
    server-urlgithub.my.fancy.corp

If you do not see a good solution either, I propose to continue with passing in server-url directly.

@zkdev zkdev force-pushed the zkdev-trusted-checkout-host-input branch from 43285ab to 46ed22d Compare January 30, 2026 11:39
@gardener-prow gardener-prow bot added the cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. label Jan 30, 2026
@zkdev zkdev changed the title enh: Expose host input of github-auth via trusted-checkout enh: Allow trusted-checkout action user to set github-server-url Jan 30, 2026
@zkdev zkdev requested review from 8R0WNI3 and ccwienk January 30, 2026 11:40
8R0WNI3
8R0WNI3 reviewed Jan 30, 2026
View reviewed changes
@gardener-robot
Copy link

gardener-robot commented Feb 2, 2026

@TuanAnh17N You have pull request review open invite, please check

@zkdev
enh: Allow trusted-checkout action user to set github-server-url
7505d12 
Useful for scenarios where trusted-checkout is used to pull repositories
from another GitHub (Enterprise) instance.

Signed-off-by: Philipp Heil (zkdev) <[email protected]>
@zkdev zkdev force-pushed the zkdev-trusted-checkout-host-input branch from 46ed22d to 7505d12 Compare February 3, 2026 08:54
@zkdev zkdev requested a review from 8R0WNI3 February 3, 2026 08:54
@gardener-prow gardener-prow bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 3, 2026
8R0WNI3
8R0WNI3 approved these changes Feb 3, 2026
View reviewed changes
Copy link
Member

@8R0WNI3 8R0WNI3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-prow
Copy link

gardener-prow bot commented Feb 3, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: 8R0WNI3

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@gardener-prow gardener-prow bot added the lgtm Indicates that a PR is ready to be merged. label Feb 3, 2026
@gardener-prow
Copy link

gardener-prow bot commented Feb 3, 2026

LGTM label has been added.

DetailsGit tree hash: ebd7490737e6375177584da37efa2b0c5aa52ff1

@gardener-prow gardener-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 3, 2026
@zkdev zkdev merged commit cb94dad into master Feb 3, 2026
21 checks passed
@zkdev zkdev deleted the zkdev-trusted-checkout-host-input branch February 3, 2026 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@8R0WNI3 8R0WNI3 8R0WNI3 approved these changes

@TuanAnh17N TuanAnh17N Awaiting requested review from TuanAnh17N TuanAnh17N is a code owner

@ccwienk ccwienk Awaiting requested review from ccwienk ccwienk is a code owner

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@zkdev @gardener-robot @ccwienk @8R0WNI3