Skip to content

fix(frontend) performance issues in main menu project selection#2715

Merged
grolu merged 8 commits intomasterfrom
enh/improve_project_selection2
Feb 5, 2026
Merged

fix(frontend) performance issues in main menu project selection#2715
grolu merged 8 commits intomasterfrom
enh/improve_project_selection2

Conversation

@grolu
Copy link
Copy Markdown
Member

@grolu grolu commented Jan 12, 2026 •
edited
Loading

What this PR does / why we need it:

Which issue(s) this PR fixes:
Fixes #2701

Special notes for your reviewer:

Release note:

grolu added 3 commits January 12, 2026 17:13
@grolu
Prefactor: Move Project Selection List to dedicated component
0cb7adc
@grolu
Use v-virtual-scroll for dynamic rendering
bddaa7c 
Removed custom dynamic rendering & scrolling logic
Use slide-y-transition to keep project list size stable during transition. This avoids issues with scrolling
@grolu
Make project tooltip lazy
395039f
@gardener-robot gardener-robot added needs/review Needs review size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. needs/second-opinion Needs second review by someone else labels Jan 12, 2026
@gardener-robot
Copy link
Copy Markdown

gardener-robot commented Jan 15, 2026

@holgerkoser, @klocke-io You have pull request review open invite, please check

@grolu grolu mentioned this pull request Jan 16, 2026
Open
petersutter
petersutter reviewed Jan 20, 2026
View reviewed changes
frontend/src/components/GMainProjectSelection.vue Outdated
:close-on-content-click="false"
:offset="[0]"
content-class="project-menu"
transition="slide-y-transition"
Copy link
Copy Markdown
Member

@petersutter petersutter Jan 19, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we need this?

@grolu
- Fixed code formatting
815e1c2 
- Fixed error when navigating with keys in case there are no projects to select
- Removed eager=false prop from tooltip as this will be disabled globally in #2730
@gardener-prow gardener-prow bot added cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jan 23, 2026
@petersutter petersutter mentioned this pull request Jan 30, 2026
Closed
grolu added 2 commits February 3, 2026 12:25
@grolu
Changed transition to avoid animation glitch
18a241d 
Fixed project tile height
Use horizontal bar to structure tiles
Extended project list height
Optimized project items computed
@grolu
Merge branch 'master' into enh/improve_project_selection2
0785a88
@gardener-prow gardener-prow bot added the do-not-merge/contains-merge-commits Indicates a PR which contains merge commits. label Feb 3, 2026
@gardener-prow
Copy link
Copy Markdown

gardener-prow bot commented Feb 3, 2026

Adding label do-not-merge/contains-merge-commits because PR contains merge commits, which are not allowed in this repository.
Use git rebase to reapply your commits on top of the target branch. Detailed instructions for doing so can be found here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@grolu grolu force-pushed the enh/improve_project_selection2 branch from 6954b49 to bceb040 Compare February 3, 2026 12:17
petersutter
petersutter reviewed Feb 3, 2026
View reviewed changes
@grolu
Copy link
Copy Markdown
Member Author

grolu commented Feb 4, 2026

/cherry-pick hotfix-1.83

@gardener-ci-robot
Copy link
Copy Markdown
Contributor

gardener-ci-robot commented Feb 4, 2026

@grolu: once the present PR merges, I will cherry-pick it on top of hotfix-1.83 in a new PR and assign it to you.

Details

In response to this:

/cherry-pick hotfix-1.83

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

petersutter
petersutter approved these changes Feb 5, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@petersutter petersutter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@grolu grolu merged commit 9a0a089 into master Feb 5, 2026
18 checks passed
@grolu grolu deleted the enh/improve_project_selection2 branch February 5, 2026 10:19
@gardener-prow gardener-prow bot added the lgtm Indicates that a PR is ready to be merged. label Feb 5, 2026
@gardener-prow
Copy link
Copy Markdown

gardener-prow bot commented Feb 5, 2026

LGTM label has been added.

DetailsGit tree hash: 78e39fc2b86d24b0ca3f09361bf1b9beec715bfa

@gardener-prow
Copy link
Copy Markdown

gardener-prow bot commented Feb 5, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: petersutter

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@gardener-prow gardener-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 5, 2026
@gardener-ci-robot
Copy link
Copy Markdown
Contributor

gardener-ci-robot commented Feb 5, 2026

@grolu: new pull request created: #2768

Details

In response to this:

/cherry-pick hotfix-1.83

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@gardener-ci-robot gardener-ci-robot mentioned this pull request Feb 5, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@petersutter petersutter petersutter approved these changes

@holgerkoser holgerkoser Awaiting requested review from holgerkoser holgerkoser is a code owner

@klocke-io klocke-io Awaiting requested review from klocke-io klocke-io is a code owner

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. do-not-merge/contains-merge-commits Indicates a PR which contains merge commits. lgtm Indicates that a PR is ready to be merged. needs/review Needs review needs/second-opinion Needs second review by someone else size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Slow Gardener dashboard

4 participants

@grolu @gardener-robot @gardener-ci-robot @petersutter