Skip to content

Conversation

@yeoldegrove
Copy link
Contributor

What this PR does / why we need it:
gardenlinux/gardenlinux#2523 and gardenlinux/gardenlinux#2427 mention the need and ideas to to put the following in the GLRD:

  • image manifest download links (on s3 bucket)
  • image download links (on s3 bucket)
  • OCI image download links (in oci/image registry)

This is all heavily "flavor" dependent information, so the flavors that are built and published for a non-virtual certain release (patch, nightly, dev) need to be tied to the GLRD entry.
The additional information that is needed to meet the 3 new features is heavily redundant ...

  • prefix of links to s3 bucket
  • prefix of oci image

... or can be derived from the type of the image (vm image or container image) and is already inside the flavor metadata:

  • links to s3 vs. links to oci

This is why in this approach the only new entry to the schema of glrd-mange and the produced json files is the addition of flavors as a dict of strings.
All other virtual fields inside flavors for metadata and image and also the oci field are generated by glrd on the fly.

Which issue(s) this PR fixes:
Fixes #2523 and #2427

Special notes for your reviewer:

  • This PR also introduces poetry for project and dependency management to better track dependencies to other python packages in git repo's.

  • Needs merge and update of dependencies in add parsing of flavors python-gardenlinux-lib#87.

  • After the merge of this PR, the existing GLRD data needs to be updated for these fields:

    • flavors
    • oci
  • This is where the new glrd-update tool can help.

glrd-update --s3-download --s3-update

@yeoldegrove yeoldegrove added the enhancement New feature or request label Feb 18, 2025
@yeoldegrove yeoldegrove added this to the 2025-02 milestone Feb 18, 2025
@yeoldegrove yeoldegrove self-assigned this Feb 18, 2025
@yeoldegrove
Copy link
Contributor Author

@NotTheEvilOne I opened #4 to coordinate the refactoring.
Minor things and the exception handling are pushed. A few questions remain.

@NotTheEvilOne NotTheEvilOne self-requested a review February 18, 2025 12:08
Copy link

@NotTheEvilOne NotTheEvilOne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks better now. Thank you :)

@yeoldegrove yeoldegrove merged commit 22f3fb0 into main Feb 18, 2025
@yeoldegrove yeoldegrove mentioned this pull request Feb 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Link release manifest files in glrd

4 participants