-
Notifications
You must be signed in to change notification settings - Fork 0
flavors, metdata/image/oci download links #3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Vincinator
reviewed
Feb 18, 2025
NotTheEvilOne
requested changes
Feb 18, 2025
Contributor
Author
|
@NotTheEvilOne I opened #4 to coordinate the refactoring. |
54b480d to
fb60f42
Compare
NotTheEvilOne
approved these changes
Feb 18, 2025
NotTheEvilOne
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks better now. Thank you :)
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
gardenlinux/gardenlinux#2523 and gardenlinux/gardenlinux#2427 mention the need and ideas to to put the following in the GLRD:
This is all heavily "flavor" dependent information, so the flavors that are built and published for a non-virtual certain release (patch, nightly, dev) need to be tied to the GLRD entry.
The additional information that is needed to meet the 3 new features is heavily redundant ...
... or can be derived from the type of the image (vm image or container image) and is already inside the flavor metadata:
This is why in this approach the only new entry to the schema of
glrd-mangeand the produced json files is the addition offlavorsas a dict of strings.All other virtual fields inside
flavorsformetadataandimageand also theocifield are generated byglrdon the fly.Which issue(s) this PR fixes:
Fixes #2523 and #2427
Special notes for your reviewer:
This PR also introduces
poetryfor project and dependency management to better track dependencies to other python packages in git repo's.Needs merge and update of dependencies in add parsing of flavors python-gardenlinux-lib#87.
After the merge of this PR, the existing GLRD data needs to be updated for these fields:
flavorsociThis is where the new
glrd-updatetool can help.