Move CName parser to a separate class
#113
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NotTheEvilOne
force-pushed
the
feature/separate-cname-class
branch
2 times, most recently
from
6951a65 to
c6a2753
Compare
Signed-off-by: Tobias Wolf <[email protected]>
NotTheEvilOne
force-pushed
the
feature/separate-cname-class
branch
from
c6a2753 to
27024d4
Compare
yeoldegrove
requested changes
May 26, 2025
Contributor
yeoldegrove
left a comment
yeoldegrove
left a comment
There was a problem hiding this comment.
Could you add a simple test for either the CLI or the function?
Signed-off-by: Tobias Wolf <[email protected]>
Signed-off-by: Tobias Wolf <[email protected]>
yeoldegrove
approved these changes
May 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR introduces
gardenlinux.features.CNameto parse and work with GardenLinux Canonical Name based parsed metadata like "flavor", "version" or "commit_id".