Skip to content

Conversation

@ByteOtter
Copy link
Contributor

@ByteOtter ByteOtter commented Aug 13, 2025

What this PR does / why we need it:

To improve general code quality (and also safety) this PR adds pyright and isort to the project for linting and import sorting respectively.

Later I will also gradually address all the errors the pyright linter finds in accordance to it's pyrightconfig.json and its strict mode rules

To not make it too noisy, I downgraded some of its default errors down to warnings if they are non-critical edge-cases or more style related than functional.

Another goal is to gradually add proper type annotations to the codebase in future PRs.

Which issue(s) this PR fixes:
Tracks (not fully fixes) #152

@ByteOtter ByteOtter changed the title CI/Lint: Add pyright and isort to the project CI/Lint: Add pyright and isort to the project Aug 13, 2025
@codecov
Copy link

codecov bot commented Aug 13, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.10%. Comparing base (d2eca70) to head (2cb552d).
⚠️ Report is 5 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #168   +/-   ##
=======================================
  Coverage   93.10%   93.10%           
=======================================
  Files          30       30           
  Lines        1348     1349    +1     
=======================================
+ Hits         1255     1256    +1     
  Misses         93       93           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ByteOtter ByteOtter marked this pull request as ready for review September 1, 2025 08:57
@ByteOtter
Copy link
Contributor Author

So far, this PR is done. The linting CI has been improved by adding isort and pyright. The current failure stems from countless pyright errors (mostly related to typing) that I would like to fix in a separate PR.

@vivus-ignis vivus-ignis merged commit 5f375b7 into main Sep 23, 2025
9 of 11 checks passed
@vivus-ignis vivus-ignis deleted the ci/add-linters branch September 23, 2025 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants