-
Notifications
You must be signed in to change notification settings - Fork 1
*.py files migrated from gardenlinux workflows #179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
vivus-ignis
wants to merge
95
commits into
main
from
3054-move-github-workflows-py-to-python-gardenlinux-lib
Closed
Changes from 91 commits
Commits
Show all changes
95 commits
Select commit
Hold shift + click to select a range
da3abe6
*.py files migrated from gardenlinux workflows
06b2f69
reorganized code, package version bump
234cad8
bumped setup action tag in flavors_parse
332329d
version 0.10.0 is the default
vivus-ignis 3ad7a9e
fixed import
vivus-ignis df1c1eb
fixed imports for sources.kernel
vivus-ignis 2ec4e57
added compare-apt-repo-versions script
vivus-ignis a3419b7
replaced compare-apt-repo-versions with python code
vivus-ignis 4dc00f5
github fixes
vivus-ignis 7011313
loading s3 bucket name from an envvar
vivus-ignis bfd7fa7
debug prints
vivus-ignis ff7965f
switched from tag to branch while we're in development mode
vivus-ignis 70b2231
flavors_parse needs to support version input too
vivus-ignis a1527ed
with block was placed in a wrong place, now fixed
vivus-ignis c2c5d05
passing the version parameter
vivus-ignis ab770f6
syntax fix
vivus-ignis 3cd9870
fixed debug print
vivus-ignis f00621b
moar debug
vivus-ignis 72d2f6f
fixed potentially wrong CName constructor call
vivus-ignis 5cdd443
updates from "upstream"
vivus-ignis 821efcf
missing import, logger for github module
vivus-ignis 23a8a14
switching from the custom requests-based code to python-apt
vivus-ignis 3c292e7
python-apt added to the poetry project
vivus-ignis eed5ba0
installing dependency for python-apt
vivus-ignis 355860b
removed libapt from setup wf
vivus-ignis 114af49
packages update; python-apt removed
vivus-ignis 85efed3
sources module is not needed anymore
vivus-ignis 2d46645
got rid of getkernelurls
vivus-ignis 7e89bd9
removed LOGGER
vivus-ignis 895c87e
release_note: update from upstream, dead code elimination
vivus-ignis e8f171d
debug print
vivus-ignis 0c40e02
the fun with short commits go on
vivus-ignis 6981bca
debugging s3 filtering
vivus-ignis cf7fca2
more debug prints
vivus-ignis 104b7ea
better filtering for metadata files download
vivus-ignis b268216
debug
vivus-ignis 5fa5d04
fixed s3 filtering
vivus-ignis 7587e26
proper debug logging
vivus-ignis b18747f
formatting fix
vivus-ignis b0abc3a
not using list for bucket objects iterator
vivus-ignis 23dd7cf
list is fine
vivus-ignis 17488b9
table-formatted diff for packages
vivus-ignis d42eac8
formatting fix
vivus-ignis 08f0a6e
removed unneccessary shell script
vivus-ignis 535e6de
simplified workflows setup
vivus-ignis a3437c1
calling gl-flavors-parse correctly
vivus-ignis 8613416
relative path to actions
vivus-ignis 3cc6051
reverting actions-related changes
vivus-ignis f417b28
which gl-* debugging
vivus-ignis 5b657d6
removed debug prints
vivus-ignis 4b0fcb1
proper logging, upload command
vivus-ignis 587faea
disable python caching when using act
vivus-ignis 943e2d3
a different approach to skip python caching with act
vivus-ignis fa6e7f8
disabled python cache configuration step
vivus-ignis de948ab
black-reformatted code
vivus-ignis a243406
black --diff makes more sense for CI
vivus-ignis 5de40e1
bandit config, requests timeouts
vivus-ignis 932fa28
reverted dev-mode changes to GHA workflows
vivus-ignis 1c948c7
Merge branch 'main' into 3054-move-github-workflows-py-to-python-gard…
vivus-ignis e22a7bb
poetry.lock updated
vivus-ignis 0ea4100
isort added to dev dependencies
vivus-ignis 3e00c6c
proper imports sorting
vivus-ignis 721a013
default exports for apt module
vivus-ignis 601ca8c
got rid of urllib
vivus-ignis c99b904
removed unused function
vivus-ignis 1c55079
constant for release id file name
vivus-ignis 83fae37
added ptpython to dev deps, cleaned up bandit excludes
vivus-ignis f789749
integration tests for release notes generation routines
vivus-ignis b22f349
working GL release notes integration test
vivus-ignis e8201bd
Merge branch 'main' into 3054-move-github-workflows-py-to-python-gard…
vivus-ignis 616321d
cosmetic fix
vivus-ignis 7b0699c
poetry deps updated
vivus-ignis c9baa93
gitpython dependency added
vivus-ignis 48fc0c4
testing get_package_list with a static Packages file
vivus-ignis 74e3ca1
isort configuration added
vivus-ignis 233613d
not using hardcoded bucket name anymore
vivus-ignis 201f372
s3_downloads added to gitignore
vivus-ignis 7dbbe20
debug log level for github module
vivus-ignis 54a2f5d
metadata download test
vivus-ignis 1c58f8d
more tests
vivus-ignis ddf2116
more tests
vivus-ignis 5e79b3c
generate coverage report in html format if run locally
vivus-ignis a24966c
working release page test with mocked s3
vivus-ignis 4b4bfba
more tests
vivus-ignis fd4991c
more tests
vivus-ignis e7fdcce
s3 bucket mocks (no fixture for now))
vivus-ignis 5d1a585
release_s3_bucket fixture
vivus-ignis f43ff13
DRYed tests
vivus-ignis 2583ffc
more tests for gods of tests
vivus-ignis b9b3851
cli args-parsing tests
vivus-ignis 4702fb7
cli tests
vivus-ignis 86c8195
extracted constants and fixtures
vivus-ignis 7cc833a
constants names fix
vivus-ignis 12df7e8
incorporated changes from gardenlinux issue #3485
vivus-ignis 6ba9dbf
Merge branch 'main' into 3054-move-github-workflows-py-to-python-gard…
vivus-ignis File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,19 +1,28 @@ | ||
| name: flavors_parse | ||
| description: Parses the given GardenLinux flavors parameters | ||
|
|
||
| inputs: | ||
| flags: | ||
| description: 'Flags passed to `gl-flavors-parse`' | ||
| description: "Flags passed to `gl-flavors-parse`" | ||
| required: true | ||
| flavors_matrix: | ||
| description: 'Generated GitHub workflow flavors matrix' | ||
| description: "Generated GitHub workflow flavors matrix" | ||
| version: | ||
| description: GardenLinux Python library version | ||
| default: "0.10.0" | ||
|
|
||
| outputs: | ||
| matrix: | ||
| description: 'Flavors matrix' | ||
| description: "Flavors matrix" | ||
| value: ${{ steps.matrix.outputs.matrix }} | ||
|
|
||
| runs: | ||
| using: composite | ||
| steps: | ||
| - uses: gardenlinux/python-gardenlinux-lib/.github/actions/[email protected] | ||
| with: | ||
| version: ${{ inputs.version }} | ||
|
|
||
| - id: matrix | ||
| shell: bash | ||
| run: | | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -169,3 +169,4 @@ bandit-report.json | |
|
|
||
| # zot | ||
| test-data/zot | ||
| s3_downloads/ | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what is the use of this parameter? is this a temporary thing for development or a permanent thing?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can specify which
python-gardenlinux-libto install using theversioninput parameter for.github/actions/setup. While this has advantages to select a known tested/working version for execution I do not see an benefit adding it toflavors_parseor ''features_parse` GitHub actions as they provide an encapsulated result (matrix or GL canonical name) for example.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure I understand what you mean by encapsulated result. flavors_parse action installs python-gardenlinux-lib. I've added version input for all actions that install this library, because otherwise the version of the library is tied to the version of CI workflow code and I think these concerns should not be mixed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove the version here. Don't see an benefit with parametrizing it here.