-
Notifications
You must be signed in to change notification settings - Fork 1
Lint: Fix features module
#218
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
76cd00a to
dd180df
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #218 +/- ##
==========================================
- Coverage 92.37% 92.36% -0.01%
==========================================
Files 40 40
Lines 1822 1821 -1
==========================================
- Hits 1683 1682 -1
Misses 139 139 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
* fixes passing of None value to non-noneable parameters in filter function
26780c3 to
bf24225
Compare
yeoldegrove
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look ok to me. Good to merge if the linting errors are fixed.
The current CI failure is a result of errors in other modules. I'm going module by module, next one is |
What this PR does / why we need it:
This PR fixes various typing and some smaller logic issues within the
featuresmodule.Fixes include:
RuntimeErrorbefore calling any filter function ifflavorisNoneto avoid passingNonevaluesValueErrorin theParserclassOptionaltype hints in cases where default values are setCallablein function signaturesnetworkx.DiGraphin the_exclude_from_filter_setfunction to avoid accessingsuccessorsofUnknowntypeWhile doing these fixes, I noticed that many values are initialized as
Noneand then treated like a regularstrtype in the code that follows. I tried to assume the most logical approach to determine if these values are allowed to beNonein their respective context.Todo:
flavorvariable in__main__.pywithout proper handlingWhich issue(s) this PR fixes:
Tracks #152