-
Notifications
You must be signed in to change notification settings - Fork 1
189 refactor new code imported from gl workflow scripts #232
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
vivus-ignis
merged 6 commits into
main
from
189-refactor-new-code-imported-from-gl-workflow-scripts
Oct 24, 2025
Merged
Changes from 3 commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
0ece6ec
not using _bucket property anymore
vivus-ignis f085996
release notes mock fixed to support quoted version numbers
vivus-ignis 7f5a5b4
calling CName constructor with the commit parameter
vivus-ignis f237e18
replaced unneeded short commit
vivus-ignis 4b8b44b
using cname.cname in download_metadata
vivus-ignis 80e2761
reverted release notes test data update to push it in a separate PR
vivus-ignis File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The
gardenlinux.features.CNameclass is capable of calculating the correct short commit hash based on the Git commit hash and defined behavior. Please do not truncate commit hashes elsewhere in the code.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This particular short commit variable is used to construct an s3 objects filter. Not sure how CName instance could help there.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Otherwise replaced its use for CName call below with full commit id.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use
commitish_short = cname.commit_idfor that purpose or directlyPrefix=f"meta/singles/{cname}-{version}-{cname.commit_id}".There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You may also use
Prefix=f"meta/singles/{cname.cname}if applicable.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Switched to using cname.cname where appropriate. cname.commit_id however doesn't work as expected and breaks tests. Will check it out in a separate PR.