Lint: Fix type errors #296
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #296 +/- ##
=======================================
Coverage 91.54% 91.55%
=======================================
Files 42 42
Lines 2070 2083 +13
=======================================
+ Hits 1895 1907 +12
- Misses 175 176 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
NotTheEvilOne
approved these changes
Jan 13, 2026
Contributor
NotTheEvilOne
left a comment
NotTheEvilOne
left a comment
There was a problem hiding this comment.
LGTM so far. We still need to work on #189 to better integrate this code.
Contributor
There was a problem hiding this comment.
Not sure if I find this syntax better readable even thought I understand the conditional import...
Contributor
Author
There was a problem hiding this comment.
Thanks for your feedback. I think I know which section you are refering to ... but I think it's unavoidable here sadly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Fixes the remaining typing errors thrown by
mypy.Adds two new dependencies:
boto3-stubsforboto3type information andmypyas dev dependency to allow setup of the dev environment via poetry.Which issue(s) this PR fixes:
Fixes #152
Special notes for your reviewer:
Release note: