Open
Conversation
When calling the "p4" program, use process functions that can have handlers for remote file names, and pass those functions the local version of the file name on the remote host where "p4" will run. The one difficult function to replace is 'call-process-region', which has no handled variant 'process-file-region'. For this we copy a process-file-region implementation from the 'xref' package.
The caller of p4--process-file-region was passing the usual "delete" parameter, but the function wasn't accepting it. The mis-match caused "Wrong type argument: stringp, nil" for some p4 commands, such as the C-c C-c (p4-form-commit) at the end of a "M-x p4-change" session. Bug introduced in previous commit, introducing p4--process-file-region
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When calling the "p4" program, use process functions that can have
handlers for remote file names, and pass those functions the local
version of the file name on the remote host where "p4" will run.
The one difficult function to replace is 'call-process-region', which
has no handled variant 'process-file-region'. For this we copy a
process-file-region implementation from the 'xref' package.