Tail calling (main) #1
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Happy to hop on a call to explain the changes I made, but here's the gist of it:
I have it building and working on native ARM and WASI, but initial performance tests have been a bit disappointing. On native targets, an easy thing to try would be to build with the latest LLVM 19 and use the preserve_none calling convention to optimize the register allocation and not have to restore register values before tail calling. I care more about Wasm performance, so I will be looking through that first, specifically getting numbers from the V8 side, which is more difficult because of lack of WASI support.