Skip to content

Conversation

@Thatoo
Copy link

@Thatoo Thatoo commented Feb 1, 2025

This is still a draft to make Nextcloud Picker very handy within Element for Nextcloud to answer this issue.
The idea is to add a button that would open Picker to select a file and get one of the three link :

  • internal link of the file
  • read only public link of the file
  • editable public link of the file
  • It requires to install the app https://github.com/nextcloud/picker on version 1.0.11 or above.

It is working but webpack isn't doing what I thought it would do. I'm not a webpack expert. I really need help on that.

So far, I still need to do this manually :

cp src/MessageComposerButtons.tsx 3rdparty/riot-web/src/components/views/rooms/MessageComposerButtons.tsx
cp css/_MessageComposer.pcss 3rdparty/riot-web/res/css/views/rooms/_MessageComposer.pcss
cd /var/www/nextcloud/apps/riotchat/3rdparty/riot-web/
rm -rf ../riot/*
cp -r webapp/* ../riot/
npm run build

if the two first line (cp command, replacing original files) could be done automatically by webpack before it builds everything, then it would work perfectly.

This was referenced Feb 1, 2025
Signed-off-by: Thatoo <[email protected]>
@Thatoo
Copy link
Author

Thatoo commented Feb 10, 2025

With this last commit, this PR now works out of the box!
I hope @gary-kim you'll have time to review it and comment it and that it will soon be merged :-)

@gary-kim gary-kim self-requested a review February 12, 2025 01:32
@gary-kim
Copy link
Owner

Sorry, I've been having a busy couple weeks. Would you mind if I update the PR to make it a patch file instead? That way, we don't have to stay as on top of keeping these modified files updated.

@Thatoo
Copy link
Author

Thatoo commented Feb 27, 2025

Sure, of course, that's what I was hoping.
Please do so.

@Gredin67
Copy link

Gredin67 commented Mar 8, 2025

how can we test ?

@Thatoo
Copy link
Author

Thatoo commented Mar 8, 2025

You can do that

git clone https://github.com/Thatoo/riotchat/tree/picker_2
cp picker_2 apps/riotchat
git submodule update --init --recursive
make

Then you activate it in nextcloud. Don't forget to install and activate the picker app to.

@Thatoo
Copy link
Author

Thatoo commented Apr 16, 2025

Sorry, I've been having a busy couple weeks. Would you mind if I update the PR to make it a patch file instead? That way, we don't have to stay as on top of keeping these modified files updated.

Hello @gary-kim did you have time to work on the patch?

@gary-kim
Copy link
Owner

Yes, I will try to take a look next week.

@Thatoo
Copy link
Author

Thatoo commented May 10, 2025

Did you manage to make it a patch file instead?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants