Skip to content

Add pyproject.toml for Custom Node Registry#2

Open
robinjhuang wants to merge 1 commit intogateway:mainfrom
ComfyNodePRs:pyproject
Open

Add pyproject.toml for Custom Node Registry#2
robinjhuang wants to merge 1 commit intogateway:mainfrom
ComfyNodePRs:pyproject

Conversation

@robinjhuang
Copy link

Hey! My name is Robin and I'm from comfy-org! We would love to have you join the Comfy Registry, a public collection of custom nodes which lets authors publish nodes by version and automate testing against existing workflows.

The registry is already integrated with ComfyUI-Manager, and we want it to be the default place users install nodes from eventually. We do a security-scan of every node to improve safety. Feel free to read up more on the registry here

  • The documentation scaffolding? You can just add the example markdown here into web/docs/MyNode.md

Action Required:

  • Go to the registry. Login and create a publisher id (everything after the @ sign on your registry profile).
  • Add the publisher id into the pyproject.toml file.
  • Merge the separate Github Actions PR, then merge this PR.

If you want to publish the node manually, install the cli by running pip install comfy-cli, then run comfy node publish

Otherwise, if you have any questions, please message me on discord at robinken or join our server!

@ArielleTolome
Copy link

Code review

Found 6 issues:

  1. pyproject.toml already exists in main with correct values — this PR would overwrite it with a broken placeholder version, losing PublisherId = "gateway", the icon URL, accurate description, version = "0.2.0", and requires-python = ">=3.10".

[project]
name = "kie-api"
description = "Integration framework for KIE Nano Banana Pro API into ComfyUI custom nodes with API key setup and placeholder for upcoming node implementations. (Description by CC)"
version = "1.0.0"
license = {file = "LICENSE"}
# classifiers = [
# # For OS-independent nodes (works on all operating systems)
# "Operating System :: OS Independent",
#
# # OR for OS-specific nodes, specify the supported systems:
# "Operating System :: Microsoft :: Windows", # Windows specific
# "Operating System :: POSIX :: Linux", # Linux specific
# "Operating System :: MacOS", # macOS specific
#
# # GPU Accelerator support. Pick the ones that are supported by your extension.
# "Environment :: GPU :: NVIDIA CUDA", # NVIDIA CUDA support
# "Environment :: GPU :: AMD ROCm", # AMD ROCm support
# "Environment :: GPU :: Intel Arc", # Intel Arc support
# "Environment :: NPU :: Huawei Ascend", # Huawei Ascend support
# "Environment :: GPU :: Apple Metal", # Apple Metal support
# ]
[project.urls]
Repository = "https://github.com/gateway/ComfyUI-Kie-API"
# Used by Comfy Registry https://registry.comfy.org
Documentation = "https://github.com/gateway/ComfyUI-Kie-API/wiki"
"Bug Tracker" = "https://github.com/gateway/ComfyUI-Kie-API/issues"
[tool.comfy]
PublisherId = ""
DisplayName = "ComfyUI-Kie-API"
Icon = ""
includes = []
# "requires-comfyui" = ">=1.0.0" # ComfyUI version compatibility

  1. PublisherId = "" is empty — Comfy Registry publishing will fail without a valid publisher ID. The existing file has PublisherId = "gateway".

  2. version = "1.0.0" is incorrect — the repo is currently at 0.2.0 per the existing pyproject.toml and README changelog. Jumping to 1.0.0 is unexplained.

  3. Package name changed from comfyui-kie-api to kie-apikie-api is too generic and risks colliding with unrelated packages in the Comfy Registry.

  4. Icon = "" is empty — the existing file provides the icon URL; this PR would clear it, removing the icon from the registry listing.

  5. Description references only "Nano Banana Pro" and "placeholder for upcoming nodes" — the repo now has 15+ node types including Kling, Seedance, Gemini, Sora 2, Suno, and Flux2.

🤖 Generated with Claude Code

- If this code review was useful, please react with 👍. Otherwise, react with 👎.

@ArielleTolome
Copy link

Code review

Found 5 issues:

  1. PR would overwrite an existing, more complete pyproject.toml — the current file already has the correct version, publisher ID, and package name

    The repo already has a pyproject.toml with version = "0.3.0", PublisherId = "gateway", name = "comfyui-kie-api", and a valid icon URL. This PR creates the file from scratch (adding as new file mode 100644), which would silently overwrite all of that. This PR should be closed; the registry fields it proposes are already present in the existing file.

  2. version = "1.0.0" regresses the current 0.3.0

    description = "Integration framework for KIE Nano Banana Pro API into ComfyUI custom nodes with API key setup and placeholder for upcoming node implementations. (Description by CC)"
    version = "1.0.0"
    license = {file = "LICENSE"}

  3. PublisherId = "" is empty — the existing file already has it set to "gateway", and a blank value will cause registry publish to fail

    [tool.comfy]
    PublisherId = ""

  4. name = "kie-api" drops the comfyui- prefix used by every node in the ecosystem and by the existing file (comfyui-kie-api)

    [project]
    name = "kie-api"
    description = "Integration framework for KIE Nano Banana Pro API into ComfyUI custom nodes with API key setup and placeholder for upcoming node implementations. (Description by CC)"

  5. Description contains unfixed placeholder text "(Description by CC)"

    name = "kie-api"
    description = "Integration framework for KIE Nano Banana Pro API into ComfyUI custom nodes with API key setup and placeholder for upcoming node implementations. (Description by CC)"
    version = "1.0.0"

🤖 Generated with Claude Code

- If this code review was useful, please react with 👍. Otherwise, react with 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants