Skip to content

fix the external URL detected as local link bug #39301

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

fix the external URL detected as local link bug #39301

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
293b16b
fix the external URL detected as local link bug
DameAwsome May 17, 2025
6dad697
fix the external URL detected as local link bug
DameAwsome May 17, 2025
feae011
fix the external URL detected as local link bug
DameAwsome May 17, 2025
8446a32
fix the external URL detected as local link bug
DameAwsome May 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions packages/gatsby-link/src/is-local-link.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,13 +1,13 @@
// Copied from https://github.com/sindresorhus/is-absolute-url/blob/3ab19cc2e599a03ea691bcb8a4c09fa3ebb5da4f/index.js
const ABSOLUTE_URL_REGEX = /^[a-zA-Z][a-zA-Z\d+\-.]*?:/
const isAbsolute = path => ABSOLUTE_URL_REGEX.test(path)
const ABSOLUTE_URL_REGEX = /^[a-zA-Z][a-zA-Z\d+\-.]*:\/\//

export const isLocalLink = path => {
function isAbsolute(path) {
return ABSOLUTE_URL_REGEX.test(path)
}

export function isLocalLink(path) {
if (typeof path !== `string`) {
return undefined
// TODO(v5): Re-Add TypeError
// throw new TypeError(`Expected a \`string\`, got \`${typeof path}\``)
}

if (!path) return false
return !isAbsolute(path)
}