feat(slices): add in-memory caching for slice content and stitched output #39335
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds two simple in-memory caches to speed up the HTML stitching process:
sliceCache - stores the raw HTML of each slice after it's read from disk
stitchedSliceCache - stores the fully-stitched version of each slice to avoid re-processing
With 5,000+ pages being stitched, we were re-reading and re-stitching the same slices many times. Most of our slices are reused heavily, so caching makes a big difference.
On local benchmarks, this reduced stitching time for 5000 pages, 8 slices into every page from ~300s to ~80s.
next steps:
by introducing workers, cold builds speeds improve from ~300s to ~35s