Skip to content

Fix: include pathPrefix in resource check to prevent 404 React crash … #39367

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
+10 −1
Open

Fix: include pathPrefix in resource check to prevent 404 React crash … #39367

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion packages/gatsby/cache-dir/loader.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -887,7 +887,16 @@ export class ProdLoader extends BaseLoader {
}
// check if html file exist using HEAD request:
// if it does we should navigate to it instead of showing 404
return doFetch(rawPath, `HEAD`).then(req => {

// OLD CODE

// return doFetch(rawPath, `HEAD`).then(req => {

// NEW FIX: include pathPrefix
const prefixedPath = __PATH_PREFIX__
? __PATH_PREFIX__ + rawPath
: rawPath
return doFetch(prefixedPath, `HEAD`).then(req => {
if (req.status === 200) {
// page (.html file) actually exist (or we asked for 404 )
// returning page resources status as errored to trigger
Expand Down