Add OpenTelemetry Prometheus metrics with configurable port/host#946
Merged
gaul merged 3 commits intogaul:masterfrom Dec 27, 2025
Merged
Add OpenTelemetry Prometheus metrics with configurable port/host#946gaul merged 3 commits intogaul:masterfrom
gaul merged 3 commits intogaul:masterfrom
Conversation
Owner
|
@hermandavid does this PR address your use case? |
Contributor
|
Metrics are useful, but this does not much relate to #923 since there are no traces being sent. Having OpenTelemetry in the project helps a lot though. I can follow up with a PR that reuses existing Jetty OTEL instrumentation and just switch it to the shaded package, so we won't have to touch shading to make it work. |
Contributor
Author
|
This PR just adds the minimal metrics setup for compliance with the OTEL spec. This covers my current observability needs already. |
Owner
|
Thank you for your contribution @klaudworks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
s3proxy.metrics.portands3proxy.metrics.hostfor Kubernetes ServiceMonitor compatibilityhttp.server.request.durationhistogram per OpenTelemetry HTTP Metrics Semantic ConventionsMetric
http.server.request.duration- Histogram of HTTP request duration in secondshttp.request.method,url.scheme,http.response.status_code,s3.operation,s3.bucketConfiguration
Sample Metrics:
Related Issues