Skip to content
This repository was archived by the owner on Jul 4, 2026. It is now read-only.

[BUG] fix issue #25 - have workflow use correct token - #27

Merged
gaureshpai merged 8 commits into
gaureshpai:mainfrom
kamikkels:main
Oct 2, 2025
Merged

[BUG] fix issue #25 - have workflow use correct token#27
gaureshpai merged 8 commits into
gaureshpai:mainfrom
kamikkels:main

Conversation

@kamikkels

@kamikkels kamikkels commented Oct 2, 2025

Copy link
Copy Markdown
Contributor

Description

Fixes the GitHub greetings workflow not working as intended

Related Issue

Fixes #25

Type of Change

  • Bug fix (non-breaking change addressing an issue)
  • New feature (non-breaking change adding functionality)
  • Breaking change (fix or feature causing existing functionality to break)
  • Documentation update

Testing

  • Ran the workflow on the forked repo to confirm the updated workflow is able to acquire a token

Checklist

  • My code follows the project's style guidelines
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Additional Notes

This update will not work on this PR, because the existing workflow file will be used, but once merged this will fix the workflow for any future PRs

@gaureshpai

Copy link
Copy Markdown
Owner

Hey @kamikkels! Do consider staring the repository, also can u please check why the ci-cd pipeline is failing with regards to report status comments and greetings again, thank you

@gaureshpai gaureshpai left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do run the workflow locally using act (check Google to know more about act) and do the needful or create PR in the fork and attach both the greetings and the status screenshots. Thank you

@kamikkels

Copy link
Copy Markdown
Contributor Author

Do run the workflow locally using act (check Google to know more about act) and do the needful or create PR in the fork and attach both the greetings and the status screenshots. Thank you

The main issue remaining is the auth level on a PR from a Fork
see actions/github-script#42 for more details

@gaureshpai

Copy link
Copy Markdown
Owner

@kamikkels check now, I've given the read-write permission to the workflow

@gaureshpai

Copy link
Copy Markdown
Owner

@kamikkels can u please provide with the screenshots of the GitHub actions running as intended in ur fork/ locally via act

@kamikkels

Copy link
Copy Markdown
Contributor Author

@gaureshpai gaureshpai left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will approve and merge this request for now, do check if it doesn't work as intended, thank you for ur contribution, do check if you have any other issue that can be taken
Thank you

@gaureshpai
gaureshpai merged commit aab91f4 into gaureshpai:main Oct 2, 2025
4 of 5 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: GitHub greetings workflow not working as intended

2 participants