Open
Conversation
Signed-off-by: Jose Luis Rivero <jrivero@osrfoundation.org>
Signed-off-by: Jose Luis Rivero <jrivero@osrfoundation.org>
azeey
reviewed
Jul 30, 2024
Signed-off-by: Jose Luis Rivero <jrivero@osrfoundation.org>
Signed-off-by: Jose Luis Rivero <jrivero@osrfoundation.org>
azeey
approved these changes
Jul 31, 2024
| mkdir -p /etc/apt/keyrings/ | ||
| for tool in colcon vcstool; do | ||
| curl -fsSL "https://packagecloud.io/dirk-thomas/${tool}/gpgkey" | gpg --dearmor > "/etc/apt/keyrings/${tool}-archive-keyring.gpg" | ||
| echo "deb [arch=$(dpkg --print-architecture) signed-by=/etc/apt/keyrings/${tool}-archive-keyring.gpg] https://packagecloud.io/dirk-thomas/${tool}/ubuntu $(. /etc/os-release && echo $UBUNTU_CODENAME) main" | sudo tee /etc/apt/sources.list.d/${tool}.list > /dev/null |
Contributor
There was a problem hiding this comment.
I see that vcstool is coming from a third-party repo as well. This probably what we want since the one in Ubuntu upstream is usually outdated, but the statement in the PR description mentions that we're using the one from upstream, so I was a little confused.
Contributor
Author
There was a problem hiding this comment.
updated the PR description
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a sidecar of #78 . Now that the use of pip for system-wide packages is restricted and dangerous, we probably want to stop using it as a package manager for our system installations.
vcs is not that critical but for colcon the use of it from a virtualenv is affecting the platform for getting system dependencies at build time, something that is more a side effect and not desired action. See the use of of colcon with system-dependencies for gz in #78.
In this PR I'm mainly getting:
python3-vcstool from Ubuntuvcstool from its packagecloud repository