More updates to bump_dependency.bash script for Jetty#1310
Open
More updates to bump_dependency.bash script for Jetty#1310
Conversation
Signed-off-by: Steve Peters <scpeters@openrobotics.org>
Signed-off-by: Steve Peters <scpeters@openrobotics.org>
Also group sed command expressions to improve readability Signed-off-by: Steve Peters <scpeters@openrobotics.org>
Replace '-' with '.' in package name regex searching to match both '-' and '_'. This improves the matching in the homebrew formula, and allows eliminating a duplicate replacement step at the very end. Signed-off-by: Steve Peters <scpeters@openrobotics.org>
Also add special handling for gz-msgs and sdformat. Signed-off-by: Steve Peters <scpeters@openrobotics.org>
83 tasks
Contributor
Author
|
there are also some |
Signed-off-by: Steve Peters <scpeters@openrobotics.org>
Contributor
Author
copied some search/replace rules to the release repo section of the script in 5f1c793 and trying the nightly build again: |
Signed-off-by: Steve Peters <scpeters@openrobotics.org>
* Use regex to match both fuel-tools, fuel_tools * Match pkg-config calls in tests/build Signed-off-by: Steve Peters <scpeters@openrobotics.org>
Signed-off-by: Steve Peters <scpeters@openrobotics.org>
Contributor
Author
|
@j-rivero this is ready for review, though I think we won't need all parts of the script anymore since we have already migrated version numbers |
Contributor
Author
|
@j-rivero should we merge or close this? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As a follow-up to #1302 and in support of bumping and removing version numbers from all Jetty packages (except gz-tools), I've made more changes to the
bump_dependency.bashscript. Almost all the changes (except to jenkins-scripts/dsl/gz-collections.yaml) are now automated. I will use this to start opening pull requests for the version bumps.Note that I ran the script with a local modification in order to customize the commit message.