Add script for creating milestones on all Gazebo libraries#1361
Open
azeey wants to merge 1 commit intogazebo-tooling:masterfrom
Open
Add script for creating milestones on all Gazebo libraries#1361azeey wants to merge 1 commit intogazebo-tooling:masterfrom
azeey wants to merge 1 commit intogazebo-tooling:masterfrom
Conversation
Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org>
j-rivero
reviewed
Sep 10, 2025
|
|
||
| for repo in $repos; do | ||
| echo "Creating milestone on gazebosim/$repo" | ||
| result=$(cat $1 | gh api --jq ".html_url" --method POST repos/gazebosim/$repo/milestones --input - 2>&1) |
Contributor
There was a problem hiding this comment.
The 68-73 lines are a bit over-complex to my eyes probably with some bugs like the use of retval instead of $retval in line 71. Can not try this easily but I would write something like:
--- a/release-collection/milestones/create_milestones.bash
+++ b/release-collection/milestones/create_milestones.bash
@@ -65,10 +65,11 @@ ros_gz
for repo in $repos; do
echo "Creating milestone on gazebosim/$repo"
- result=$(cat $1 | gh api --jq ".html_url" --method POST repos/gazebosim/$repo/milestones --input - 2>&1)
- retval=$?
- echo " url: $result"
- if [[ retval -ne 0 ]]; then
+ result=$(gh api --jq ".html_url" --method POST "repos/gazebosim/$repo/milestones" --input "$1" 2>&1)
+ if [[ $? -eq 0 ]]; then
+ echo " url: $result"
+ else
+ echo "Error: $result" >&2
exit 1
fi
done
Contributor
|
One patch and we are good to go @azeey |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tools and data to create milestones on all Gazebo
libraries as it is not currently possible to share a milestone between different
Github repositories. Instead, we create a milestone with the same name on all
the repos and use queries like
milestone:"Jetty Release"to filter pull request/issues. This is typically done during preparation for the
release of a collection (e.g. Gazebo Jetty).
AI Note: Generated using Gemini 2.5 Pro