Skip to content

Check for gh tool during sanity checks #1436

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
j-rivero wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Check for gh tool during sanity checks #1436

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions release.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -412,6 +412,13 @@ def sanity_check_bump_linux(source_tarball_uri):
'to call builders and not source generation')


def sanity_check_gh_tool():
if shutil.which('gh') is None:
error("The 'gh' (GitHub CLI) tool is required but was not found in PATH.\n"
"Please install it from: https://cli.github.com/")
print_success("GitHub CLI (gh) tool is available")


def sanity_checks(args, repo_dir):
print("Safety checks:")
sanity_package_name_underscore(args.package, args.package_alias)
Expand All @@ -431,6 +438,7 @@ def sanity_checks(args, repo_dir):
sanity_check_cmake_version(args.package, args.version)
sanity_project_package_in_stable(args.version, args.upload_to_repository)

sanity_check_gh_tool()
check_credentials(args.auth_input_arg)
print_success("Jenkins credentials are good")
shutil.rmtree(repo_dir)
Expand Down