Remove warning configuration from homebrew bottle builder#408
Open
Remove warning configuration from homebrew bottle builder#408
Conversation
scpeters
reviewed
Sep 10, 2021
| def bottle_job_builder = matrixJob(bottle_builder_job_name) | ||
| // set enable_github_pr_integration flag to false so we can customize trigger behavior | ||
| OSRFBrewCompilationAnyGitHub.create(bottle_job_builder, | ||
| "osrf/homebrew-simulation", |
Contributor
There was a problem hiding this comment.
does it work without OSRFBrewCompilationAnyGitHub and the "osrf/homebrew-simulation" parameter? I'm not sure how it would attach to pull requests without that configuration
Contributor
Author
There was a problem hiding this comment.
good catch, changes are broken indeed. I tried to solve them in c7053c3. The new diff seems much better:
--- generic-release-homebrew_triggered_bottle_builder.xml 2021-10-06 17:00:03.366135806 +0200
+++ /tmp/generic-release-homebrew_triggered_bottle_builder.xml 2021-10-06 16:59:21.924941433 +0200
@@ -261,37 +261,6 @@
<saveOutput>false</saveOutput>
<disabled>false</disabled>
</hudson.plugins.emailext.ExtendedEmailPublisher>
- <io.jenkins.plugins.analysis.core.steps.IssuesRecorder>
- <analysisTools>
- <io.jenkins.plugins.analysis.warnings.Clang>
- <id></id>
- <name></name>
- <pattern></pattern>
- <reportEncoding></reportEncoding>
- <skipSymbolicLinks>false</skipSymbolicLinks>
- </io.jenkins.plugins.analysis.warnings.Clang>
- </analysisTools>
- <sourceCodeEncoding></sourceCodeEncoding>
- <ignoreQualityGate>false</ignoreQualityGate>
- <ignoreFailedBuilds>true</ignoreFailedBuilds>
- <referenceJobName></referenceJobName>
- <healthy>0</healthy>
- <unhealthy>0</unhealthy>
- <minimumSeverity>
- <name>LOW</name>
- </minimumSeverity>
- <filters></filters>
- <isEnabledForFailure>false</isEnabledForFailure>
- <isAggregatingResults>false</isAggregatingResults>
- <isBlameDisabled>false</isBlameDisabled>
- <qualityGates>
- <io.jenkins.plugins.analysis.core.util.QualityGate>
- <threshold>1</threshold>
- <type>TOTAL</type>
- <status>WARNING</status>
- </io.jenkins.plugins.analysis.core.util.QualityGate>
- </qualityGates>
- </io.jenkins.plugins.analysis.core.steps.IssuesRecorder>
<hudson.tasks.ArtifactArchiver>
<artifacts>pkgs/*</artifacts>
<allowEmptyArchive>true</allowEmptyArchive>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Made a quick draft on the change that should allow disable warnings configuration in brew bottle builder, issue #407. Seems to me like we are not using any of the GitHub configurations in the GitHubAny class so I removed it and use the BrewCompilation adding the option of disabling warnings. We are also losing the github checkout but it is my impression that is not being really used by the scripts.
I just run a quick diff on the XML generated with the old and the new DSL:
It needs testing in the buildfarm.