Use PR comments to display diffs in DSL->Jenkins changes#831
Open
Use PR comments to display diffs in DSL->Jenkins changes#831
Conversation
Signed-off-by: Jose Luis Rivero <jrivero@osrfoundation.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change the #794 to display the diffs between Jenkins XML config files generated for changes in the PR to use a comment in PR instead of exporting artifacts in Github Actions. Convenient to save 4-5 clicks, download and open different files when looking a PR.
The changes in the code are ugly since the handle of multiline output in combination with using ``` inside the github action brings many problems.
See it in action: j-rivero#3 (comment)
Before merging: it needs a token from an existing GitHub user with
public_repocredentials inUSER_TOKEN. The idea is to use @osrf-jenkins or @gazebosim to do it.