Skip to content

MeshManager improvement #691

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: gz-common6
Choose a base branch
from
Open

MeshManager improvement #691

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
22b9d9d
MeshManager improvement
ntfshard Jun 14, 2025
51db501
Review iteration
ntfshard Jun 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion geospatial/src/ImageHeightmap.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,6 @@ void ImageHeightmap::FillHeightMap(int _subSampling,
imgFormat == common::Image::PixelFormatType::BAYER_BGGR8 ||
imgFormat == common::Image::PixelFormatType::BAYER_GBRG8 ||
imgFormat == common::Image::PixelFormatType::BAYER_GRBG8 ||
imgFormat == common::Image::PixelFormatType::BAYER_GRBG8 ||
Comment on lines 69 to -70
Copy link
Contributor Author

@ntfshard ntfshard Jun 19, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same line twice
(re-pushed commit due to CI on Windows complained about temp dir)

imgFormat == common::Image::PixelFormatType::BAYER_RGGB8 ||
imgFormat == common::Image::PixelFormatType::BGR_INT8 ||
imgFormat == common::Image::PixelFormatType::BGRA_INT8)
Expand Down
1 change: 0 additions & 1 deletion graphics/include/gz/common/MeshManager.hh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,6 @@
#ifndef GZ_COMMON_MESHMANAGER_HH_
#define GZ_COMMON_MESHMANAGER_HH_

#include <map>
#include <utility>
#include <string>
#include <vector>
Expand Down
Loading
Loading