Skip to content

Conversation

@mergify
Copy link
Contributor

@mergify mergify bot commented Oct 16, 2025

Summary

  • Requested by @azeey from gz-common: Profiler gazebo_test_cases#1749
  • Explicitly create new project directory called profiler_example
  • Download profiler.cc into directory using wget
  • Remove unnecessary grep dependency
  • Clarify the CMakeLists is being created, not modified
  • Separate the different options for running the profiler visualization into multiple blocks, with the conditions described more clearly
  • Would like confirmation on what IP address http.server broadcasts to; tutorial says it's the container's IP address, but it always showed up as 0.0.0.0 (localhost) for me in my container
  • I looked through the contributing guidelines and couldn't find any information on linting tests or formatting standards for these Markdown files, so please point me to them if available!

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers
  • Was GenAI used to generate this PR? If so, make sure to add "Generated-by" to your commits. (See this policy for more info.)

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by and Generated-by messages.


This is an automatic backport of pull request #711 done by Mergify.

- Explicitly create new project directory called profiler_example
- Download profiler.cc into directory using wget
- Remove unnecessary grep dependency
- Clarify the CMakeLists is being created, not modified
- Separate the different options for running the profiler visualization
  into multiple blocks, with the conditions described more clearly
- Would like confirmation on what IP address http.server broadcasts to;
  tutorial says it's the container's IP address, but it always showed up
  as 0.0.0.0 (localhost) for me in my container

Signed-off-by: Harrison Chen <[email protected]>
Co-authored-by: Addisu Z. Taddese <[email protected]>
(cherry picked from commit 2b33445)

# Conflicts:
#	tutorials/profiler.md
@mergify mergify bot added the conflicts label Oct 16, 2025
@mergify
Copy link
Contributor Author

mergify bot commented Oct 16, 2025

Cherry-pick of 2b33445 has failed:

On branch mergify/bp/gz-common6/pr-711
Your branch is up to date with 'origin/gz-common6'.

You are currently cherry-picking commit 2b33445.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   tutorials/profiler.md

no changes added to commit (use "git add" and/or "git commit -a")

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Inbox

Development

Successfully merging this pull request may close these issues.

2 participants