Skip to content

Fix gz test on windows#131

Merged
mjcarroll merged 1 commit intogazebosim:gz-plugin2from
azeey:fix_windows_gz
Nov 13, 2023
Merged

Fix gz test on windows#131
mjcarroll merged 1 commit intogazebosim:gz-plugin2from
azeey:fix_windows_gz

Conversation

@azeey
Copy link
Contributor

@azeey azeey commented Nov 10, 2023

🦟 Bug fix

Fixes #129

Summary

This is another attempt to fix UNIT_gz_TEST on windows. It needs gazebo-tooling/gazebodistro#163 and gazebo-tooling/release-tools#1063

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org>
@github-actions github-actions bot added 🌱 garden Ignition Garden 🎵 harmonic Gazebo Harmonic labels Nov 10, 2023
@codecov
Copy link

codecov bot commented Nov 10, 2023

Codecov Report

Merging #131 (51b7120) into gz-plugin2 (0112b4d) will not change coverage.
Report is 9 commits behind head on gz-plugin2.
The diff coverage is 100.00%.

❗ Current head 51b7120 differs from pull request most recent head c4c6cd7. Consider uploading reports for the commit c4c6cd7 to get more accurate results

@@             Coverage Diff             @@
##           gz-plugin2     #131   +/-   ##
===========================================
  Coverage       98.26%   98.26%           
===========================================
  Files              23       23           
  Lines             748      748           
===========================================
  Hits              735      735           
  Misses             13       13           
Files Coverage Δ
core/src/utility.cc 100.00% <100.00%> (ø)

@azeey
Copy link
Contributor Author

azeey commented Nov 10, 2023

Test build with release-tools and gazebodistro PRs: Build Status

@azeey azeey marked this pull request as ready for review November 10, 2023 23:01
@azeey azeey requested review from ahcorde and mxgrey as code owners November 10, 2023 23:01
@mjcarroll mjcarroll merged commit 944bd8c into gazebosim:gz-plugin2 Nov 13, 2023
@azeey azeey deleted the fix_windows_gz branch November 13, 2023 16:11
@azeey
Copy link
Contributor Author

azeey commented Nov 13, 2023

Can I get a ✅ on gazebo-tooling/gazebodistro#163 as well? The release-tools PR will need to wait.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🌱 garden Ignition Garden 🎵 harmonic Gazebo Harmonic

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

gz_TEST not running on Windows CI

3 participants