Require cmake 3.10.2 for consistency (backport #162)#164
Merged
scpeters merged 1 commit intoign-plugin1from Feb 10, 2025
Merged
Require cmake 3.10.2 for consistency (backport #162)#164scpeters merged 1 commit intoign-plugin1from
scpeters merged 1 commit intoign-plugin1from
Conversation
8 tasks
Member
|
I'll amend the commit message to refer to Fortress instead of harmonic |
A more recent version of cmake is already required for other Fortress dependencies, such as ign-cmake2, so increase the required version here to fix a warning. Signed-off-by: Steve Peters <scpeters@openrobotics.org> (cherry picked from commit bdcca3c) (reworded to refer to Fortress instead of Harmonic)
scpeters
force-pushed
the
mergify/bp/ign-plugin1/pr-162
branch
from
c873580 to
efc0c5b
Compare
Member
done in efc0c5b |
scpeters
approved these changes
Feb 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🦟 Bug fix
Fixes #160
Summary
A more recent version of cmake is already required for other Fortress dependencies, such as ign-cmake2, so increase the required version here to fix a warning.
Checklist
codecheckpassed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-bymessages.This is an automatic backport of pull request #162 done by [Mergify](https://mergify.com).