Skip to content

Suppress a new Jammy warning (backport #85)#199

Merged
scpeters merged 1 commit intoign-plugin1from
mergify/bp/ign-plugin1/pr-85
Jan 15, 2026
Merged

Suppress a new Jammy warning (backport #85)#199
scpeters merged 1 commit intoign-plugin1from
mergify/bp/ign-plugin1/pr-85

Conversation

@mergify
Copy link
Copy Markdown
Contributor

@mergify mergify bot commented Jan 15, 2026

/home/mjcarroll/workspaces/gz_garden/src/gz-plugin/test/integration/factory.cc: In member function ‘virtual void Factory_Alias_Test::TestBody()’:
/home/mjcarroll/workspaces/gz_garden/src/gz-plugin/test/integration/factory.cc:118:27: warning: loop variable ‘alias’ of type ‘const string&’ {aka ‘const std::__cxx11::basic_string<char>&’} binds to a temporary constructed from type ‘const char* const’ [-Wrange-loop-construct]
  118 |   for (const std::string &alias : {
      |                           ^~~~~
/home/mjcarroll/workspaces/gz_garden/src/gz-plugin/test/integration/factory.cc:118:27: note: use non-reference type ‘const string’ {aka ‘const std::__cxx11::basic_string<char>’} to make the copy explicit or ‘const char* const&’ to prevent copying

Signed-off-by: Michael Carroll michael@openrobotics.org


This is an automatic backport of pull request #85 done by Mergify.

Signed-off-by: Michael Carroll <michael@openrobotics.org>
(cherry picked from commit 8426cd6)
@mergify mergify bot requested a review from ahcorde as a code owner January 15, 2026 21:30
@mergify mergify bot mentioned this pull request Jan 15, 2026
@github-actions github-actions bot added the 🏯 fortress Ignition Fortress label Jan 15, 2026
@github-project-automation github-project-automation bot moved this from Inbox to In review in Core development Jan 15, 2026
@scpeters scpeters merged commit 4fc6e34 into ign-plugin1 Jan 15, 2026
12 checks passed
@scpeters scpeters deleted the mergify/bp/ign-plugin1/pr-85 branch January 15, 2026 22:00
@github-project-automation github-project-automation bot moved this from In review to Done in Core development Jan 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🏯 fortress Ignition Fortress

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

2 participants