Skip to content

Comments

Bazel updates (backport #744)#746

Merged
iche033 merged 2 commits intomainfrom
mergify/bp/main/pr-744
Dec 11, 2025
Merged

Bazel updates (backport #744)#746
iche033 merged 2 commits intomainfrom
mergify/bp/main/pr-744

Conversation

@mergify
Copy link
Contributor

@mergify mergify bot commented Nov 7, 2025

🦟 Bug fix

Summary

Small bugfix in bazel build:

  • Add HAVE_IFADDRS=1 define to suppress warnings

Other bazel maintenance updates:

  • Bump minor/patch/bcr versions for googletest and protobuf.
  • Add buildifier linting to BUILD.bazel (covers all BUILD.bazel files)
  • Drop repo name from MODULE.bazel
  • Add rules_cc dep and replace native cc_* rules with those from rules_cc in all BUILD.bazel files (required by buildifier).
  • Enable unit tests in log/BUILD.bazel
  • Add targets for integration tests in test/BUILD.bazel

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers
  • Was GenAI used to generate this PR? If so, make sure to add "Generated-by" to your commits. (See this policy for more info.)

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by and Generated-by messages.


This is an automatic backport of pull request #744 done by Mergify.

@mergify mergify bot requested a review from caguero as a code owner November 7, 2025 20:05
@mergify mergify bot added the conflicts label Nov 7, 2025
@mergify
Copy link
Contributor Author

mergify bot commented Nov 7, 2025

Cherry-pick of fe5dfb7 has failed:

On branch mergify/bp/main/pr-744
Your branch is up to date with 'origin/main'.

You are currently cherry-picking commit fe5dfb7.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   MODULE.bazel
	modified:   log/BUILD.bazel
	modified:   parameters/BUILD.bazel
	modified:   test/BUILD.bazel

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   BUILD.bazel

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

@mergify mergify bot mentioned this pull request Nov 7, 2025
9 tasks
@iche033 iche033 marked this pull request as draft November 7, 2025 21:52
@iche033
Copy link
Contributor

iche033 commented Nov 8, 2025

@Mergifyio rebase

@mergify
Copy link
Contributor Author

mergify bot commented Nov 8, 2025

rebase

❌ Unable to rebase: Mergify can't impersonate iche033

Details

User iche033 used as bot_account is unknown. Please make sure {login} exists and has logged into the Mergify dashboard.

@iche033 iche033 force-pushed the mergify/bp/main/pr-744 branch 2 times, most recently from 4ef995b to cb0ebdb Compare November 10, 2025 19:09
@iche033 iche033 marked this pull request as ready for review November 10, 2025 19:45
@iche033
Copy link
Contributor

iche033 commented Nov 10, 2025

this is ready for review

@iche033 iche033 removed the conflicts label Nov 10, 2025
@github-project-automation github-project-automation bot moved this from Inbox to In review in Core development Dec 11, 2025
@shameekganguly
Copy link
Contributor

CI failure seems to be unrelated.

* Bazel updates


Signed-off-by: Shameek Ganguly <shameek@intrinsic.ai>
@iche033 iche033 force-pushed the mergify/bp/main/pr-744 branch from cb0ebdb to 0bde115 Compare December 11, 2025 21:28
@iche033
Copy link
Contributor

iche033 commented Dec 11, 2025

the ubuntu github actions and gz_transport-ci-pr_any-noble-amd64 build should be fixed by #752

@scpeters
Copy link
Member

the homebrew test failures should be fixed by #751; let's wait for that and then update the branch and CI should be clean

@iche033
Copy link
Contributor

iche033 commented Dec 11, 2025

CI is green, merging!

@iche033 iche033 merged commit dea15ac into main Dec 11, 2025
14 checks passed
@iche033 iche033 deleted the mergify/bp/main/pr-744 branch December 11, 2025 23:44
@github-project-automation github-project-automation bot moved this from In review to Done in Core development Dec 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

4 participants