Conversation
Contributor
Author
|
Cherry-pick of fe5dfb7 has failed: To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally |
Contributor
|
@Mergifyio rebase |
Contributor
Author
❌ Unable to rebase: Mergify can't impersonate
|
4ef995b to
cb0ebdb
Compare
Contributor
|
this is ready for review |
caguero
approved these changes
Dec 11, 2025
Contributor
|
CI failure seems to be unrelated. |
* Bazel updates Signed-off-by: Shameek Ganguly <shameek@intrinsic.ai>
cb0ebdb to
0bde115
Compare
Contributor
|
the ubuntu github actions and gz_transport-ci-pr_any-noble-amd64 build should be fixed by #752 |
Member
|
the homebrew test failures should be fixed by #751; let's wait for that and then update the branch and CI should be clean |
Contributor
|
CI is green, merging! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🦟 Bug fix
Summary
Small bugfix in bazel build:
HAVE_IFADDRS=1define to suppress warningsOther bazel maintenance updates:
rules_ccdep and replace nativecc_*rules with those from rules_cc in all BUILD.bazel files (required by buildifier).log/BUILD.bazeltest/BUILD.bazelChecklist
codecheckpassed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-byandGenerated-bymessages.This is an automatic backport of pull request #744 done by Mergify.