Skip to content

Added descriptions to gz_server and ros_gz_sim launch files (backport #838)#840

Merged
ahcorde merged 1 commit intojazzyfrom
mergify/bp/jazzy/pr-838
Feb 10, 2026
Merged

Added descriptions to gz_server and ros_gz_sim launch files (backport #838)#840
ahcorde merged 1 commit intojazzyfrom
mergify/bp/jazzy/pr-838

Conversation

@mergify
Copy link
Contributor

@mergify mergify bot commented Feb 10, 2026

🎉 New feature

Summary

I've added descriptions to args in gz_server.launch(|.py) and ros_gz_sim.launch(|.py).

I've also added propagation of initial_sim_time (was forgotten when it was added) and verbosity_level (new parameter added yesterday).

Test it

ros2 launch ros_gz_sim ros_gz_sim.launch --show-args
ros2 launch ros_gz_sim ros_gz_sim.launch.py --show-args
ros2 launch ros_gz_sim gz_server.launch --show-args
ros2 launch ros_gz_sim gz_server.launch.py --show-args
ros2 launch ros_gz_sim gz_server.launch world_sdf_file:=empty.sdf verbosity_level:=1 initial_sim_time:=100.0
gz topic -e -t /clock  # expect values starting with 100.0 s

However, #803 makes it impossible to test actually running the ros_gz_sim.launch files as I get:

[ERROR] [launch]: Caught exception in launch (see debug for traceback): Caught multiple exceptions when trying to load file of format [py]:
 - TypeError: 'RosGzBridge' expected 'bridge_params' to be one of [<class 'list'>], but got '<launch.substitutions.launch_configuration.LaunchConfiguration object at 0x7cd237a54f20>' of type '<class 'launch.substitutions.launch_configuration.LaunchConfiguration'>'
 - InvalidFrontendLaunchFileError: The launch file may have a syntax error, or its format is unknown

I suggest removing bridge_params from the launch file completely as was suggested in some of the discussions around #664 .

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers
  • Was GenAI used to generate this PR? If so, make sure to add "Generated-by" to your commits. (See this policy for more info.)

Generated-by: Human

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by and Generated-by messages.


This is an automatic backport of pull request #838 done by Mergify.

Signed-off-by: Martin Pecka <peckama2@fel.cvut.cz>
(cherry picked from commit 6247cb0)
@github-project-automation github-project-automation bot moved this from Inbox to In review in Core development Feb 10, 2026
@ahcorde ahcorde merged commit b42f00f into jazzy Feb 10, 2026
8 checks passed
@ahcorde ahcorde deleted the mergify/bp/jazzy/pr-838 branch February 10, 2026 12:46
@github-project-automation github-project-automation bot moved this from In review to Done in Core development Feb 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

2 participants