Use GID filtering to prevent loops (backport #834)#842
Merged
Conversation
Signed-off-by: Carlos Aguero <caguero@osrfoundation.org> Co-authored-by: Alejandro Hernández Cordero <ahcorde@gmail.com> (cherry picked from commit f33322a)
9 tasks
ahcorde
approved these changes
Feb 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🦟 Bug fix
Fixes #788.
Summary
As mentioned in the issue,
ignore_local_publicationsis hardcoded totrueinfactory.hpp. This DDS optionfilters by DDS participant, not by node. In composition, all nodes share the same DDS participant, so messages from all sibling nodes are dropped.
The proposed fix is to replace
ignore_local_publicationswith publisher GID-based filtering. At subscription creation time, the bridge collects its own publisher GIDs on the topic. In the callback, it compares each incoming message's publisher GID against that list and skips matches. This prevents loops in bidirectional bridges while allowing messages from other composed nodes.I think the Gz transport side (
SetIgnoreLocalMessages(true)) is OK because it works at thegz::transport::Nodelevel, not the process level, so it should work correctly.Checklist
codecheckpassed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-byandGenerated-bymessages.This is an automatic backport of pull request #834 done by Mergify.