Draft
Conversation
Signed-off-by: Guillaume Ballet <3272758+gballet@users.noreply.github.com>
e5d5e09 to
4a2f6fb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a tracking issue. This benchmark is very similar to the one in go-verkle, but it adds the tree key computation and not just the root commitment.
This is still incomplete, because the tree isn't pre-seeded with data. It would ideally take a converted database, which I'm currently generating.
This is a pretty beefy machine, and the total insertion + root computation is ~250ms for a "conversion stage" payload.
This is running inside a VM on a Snapdragon 8cx Gen3 8 core processor:
The same payload takes double the time, 500ms.